Issue 1736: Three bugs of FCICreate (PC/_msi.c) (original) (raw)

Created on 2008-01-04 14:53 by ocean-city, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (5)
msg59228 - (view)	Author: Hirokazu Yamamoto (ocean-city) *	Date: 2008-01-04 14:53
I have fixed three bugs of msilib.FCICreate() 1. msilib.FCICreate("a.cab") creates ".a.cab" (extra leading dot) In recent cab SDK's FCI-FDI.doc, # quote start The szCab field should contain a string which contains the name of the first cabinet to be created (e.g. “APP1.CAB”). In the event of multiple cabinets being created, the GetNextCab function called by the FCIAddFile API allows subsequent cabinet names to be specified. The szCabPath field should contain the complete path of where to create the cabinet (e.g. “C:\MYFILES\”). # quote end Currently, _msi.c separate "C:\\MYFILES\\APP1.CAB" to szCabPath "C:" and szCab "\\MYFILES\\APP1.CAB". 2. Probably, "long names" error check doesn't count null-terminator now. 3. Usually, multibyte character may contain "\\" as trailing-byte. (like "ソ" in Japanese) Not to count this as path separator, I used CharNext(). Thank you.
msg61557 - (view)	Author: Hirokazu Yamamoto (ocean-city) *	Date: 2008-01-23 06:05
Sorry, I lied. What I said in bug 2 was totally wrong. Meaning of 'i' was changed from original code and my patch. There is no problem about buffer length. Thank you.
msg61581 - (view)	Author: Hirokazu Yamamoto (ocean-city) *	Date: 2008-01-23 14:26
Umm, please forget previous comment. >>> msilib.FCICreate("a" * 256 + "/" + "b" * 255, []) crashed on debug build. (CB_MAX_CAB_PATH == 256)
msg62247 - (view)	Author: Hirokazu Yamamoto (ocean-city) *	Date: 2008-02-10 09:48
Refactored a little. More clean diff.
msg62317 - (view)	Author: Martin v. Löwis (loewis) *	Date: 2008-02-12 13:48
Thanks for the patch. Committed as r60743 and r60744.