Issue 17391: _cursesmodule Fails to Build on GCC 2.95 (static) (original) (raw)

Created on 2013-03-10 14:18 by Jeffrey.Armstrong, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg183877 - (view)	Author: Jeffrey Armstrong (Jeffrey.Armstrong) *	Date: 2013-03-10 14:18
When compiling Modules/_cursesmodule.c as a static module with GCC 2.95.3, an error is encountered on line 2260 in PyCurses_GetWin. The error occurs because the PyCursesInitialised macro appears prior _Py_IDENTIFIER(read), which is actually a variable declaration. Switching the order of the statements fixes the issue. In all other functions within Modules/_cursesmodule.c, PyCursesInitialised always appears after all variable declarations. This bug was encountered on the platform m68k-atari-mint using Python 3.3.0 and GCC 2.95.3.
msg223260 - (view)	Author: Mark Lawrence (BreamoreBoy) *	Date: 2014-07-16 19:40
Can we have a review of the one line patch please.
msg223695 - (view)	Author: Charles-François Natali (neologix) *	Date: 2014-07-22 20:51
Jerrfey, thanks for your patch, but apparently in the - long - meantime, the declaration has already been moved up.
msg223697 - (view)	Author: Jeffrey Armstrong (Jeffrey.Armstrong) *	Date: 2014-07-22 20:59
Next time I see a bug I'll be sure to wait rather than actually submit a patch...
msg223699 - (view)	Author: Charles-François Natali (neologix) *	Date: 2014-07-22 21:16
> Jeffrey Armstrong added the comment: > > Next time I see a bug I'll be sure to wait rather than actually submit a patch... I understand your frustration, but please don't do that: you have to understand that we don't have any automatic reminder of issues, so it can happen that some go unnoticed, especially if no core developer is assigned. Is this happens in the future, simply send an email on the python-dev mailing list saying that you've got a patch waiting for review, this shoud do the trick.