Issue 1746: ZIP files with archive comments longer than 4k not recognized as valid by zipfile module (original) (raw)

Issue1746

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification

Title:	ZIP files with archive comments longer than 4k not recognized as valid by zipfile module
Type:	behavior	Stage:
Components:	Library (Lib)	Versions:	Python 2.6

process

Status:	closed	Resolution:	fixed
Dependencies:		Superseder:
Assigned To:		Nosy List:	alanmcintyre, jcea, loewis
Priority:	normal	Keywords:

Created on 2008-01-06 22:40 by alanmcintyre, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (3)
msg59411 - (view)	Author: Alan McIntyre (alanmcintyre) *	Date: 2008-01-06 22:40
The current behavior of zipfile._EndRecData is to look in the last 4k of data in a file if it appears it might have an archive comment; this results in flagging proper ZIP files with comments longer than ~4074 bytes as "not a ZIP file." I plan on posting a patch for this later, but figured this should be documented in case I don't get around to it.
msg59805 - (view)	Author: Alan McIntyre (alanmcintyre) *	Date: 2008-01-12 10:15
A fix for this is included in the patch for issue 1622.
msg69196 - (view)	Author: Martin v. Löwis (loewis) *	Date: 2008-07-03 12:54
The patch in #1622 was committed as r64688.

History
Date	User	Action	Args
2022-04-11 14:56:29	admin	set	github: 46087
2008-07-03 12:54:21	loewis	set	nosy: + loewisresolution: duplicate -> fixedmessages: +
2008-03-18 02:45:26	jafo	set	status: open -> closedpriority: normalresolution: duplicate
2008-01-16 02:36:40	jcea	set	nosy: + jcea
2008-01-12 10:15:00	alanmcintyre	set	messages: +
2008-01-06 22:40:16	alanmcintyre	create