Issue 1748: contextlib.contextmanager does not use functools.wraps (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/46089

classification

Title: contextlib.contextmanager does not use functools.wraps
Type: behavior Stage:
Components: Library (Lib) Versions: Python 2.6

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ncoghlan Nosy List: benjamin.peterson, georg.brandl, ncoghlan, pitrou
Priority: low Keywords:

Created on 2008-01-06 22:59 by pitrou, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (3)
msg59413 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2008-01-06 22:59
The contextmanager function should call functools.wraps instead of having its own attribute copying code. Just something I noticed while reading the source.
msg66024 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-04-30 21:00
Can this be fixed?
msg66025 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2008-04-30 21:08
Done in r62605.
History
Date User Action Args
2022-04-11 14:56:29 admin set github: 46089
2008-04-30 21:08:56 georg.brandl set status: open -> closedresolution: fixedmessages: + nosy: + georg.brandl
2008-04-30 21:00:38 benjamin.peterson set nosy: + benjamin.petersonmessages: +
2008-01-07 16:42:51 georg.brandl set priority: lowtype: behavior
2008-01-06 23:34:17 georg.brandl set assignee: ncoghlannosy: + ncoghlan
2008-01-06 22:59:04 pitrou create