Issue 17691: Fix test discovery for test_univnewlines.py (original) (raw)

Issue17691

Created on 2013-04-10 19:19 by zach.ware, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_univnewlines_discovery.diff zach.ware,2013-04-10 19:19 test_univnewlines.py fix, version 1 review
test_univnewlines_discovery.v2.diff zach.ware,2013-05-28 15:03 Version 2 review
Messages (4)
msg186527 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-04-10 19:19
Inheritance issues again. This one has some magic in test_main to create the C and Python tests programmatically which I felt was best left alone, so the patch simply converts test_main into a load_tests which ignores its arguments.
msg190217 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-05-28 15:03
Looking at this again, the test_main magic wasn't too arcane, so here's a patch that does away with test_main (or load_tests) completely.
msg190825 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-06-08 21:10
New changeset a2e093e98d45 by Ezio Melotti in branch '3.3': #17691: test_univnewlines now works with unittest test discovery. Patch by Zachary Ware. http://hg.python.org/cpython/rev/a2e093e98d45 New changeset d1b5e41acf28 by Ezio Melotti in branch 'default': #17691: merge with 3.3. http://hg.python.org/cpython/rev/d1b5e41acf28
msg190826 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-06-08 21:10
Fixed, thanks for the patch!
History
Date User Action Args
2022-04-11 14:57:44 admin set github: 61891
2013-06-08 22:09:12 ezio.melotti set assignee: ezio.melotti
2013-06-08 21:10:55 ezio.melotti set status: open -> closedresolution: fixedmessages: + stage: resolved
2013-06-08 21:10:24 python-dev set nosy: + python-devmessages: +
2013-05-28 15:03:49 zach.ware set files: + test_univnewlines_discovery.v2.diffmessages: +
2013-04-10 19:19:05 zach.ware create