Issue 17699: Fix test_getpass on Windows (original) (raw)

Issue17699

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/61899

classification

process

Created on 2013-04-11 20:29 by zach.ware, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg186588 - (view)	Author: Zachary Ware (zach.ware) *	Date: 2013-04-11 20:29
(Copied the nosy list from ) The new test module fails on Windows due to the lack of termios and pwd modules. Here's a patch that fixes things. I suspect the skip condition on UnixGetpassTest could be changed to check 'termios' rather than os.name, but I can't test that currently. Thanks, Zach
msg186596 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-04-11 21:47
New changeset c84a5e5f73c3 by R David Murray in branch 'default': #17699: Fix the new getpass test failures on windows. http://hg.python.org/cpython/rev/c84a5e5f73c3
msg186597 - (view)	Author: R. David Murray (r.david.murray) *	Date: 2013-04-11 21:48
Thanks Zachary. I forgot to check the buildbots after I pushed that patch.
msg186598 - (view)	Author: R. David Murray (r.david.murray) *	Date: 2013-04-11 21:56
I'm going to close this because the windows buildbots currently aren't building, and I'll forget to close it if I wait for them. I trust you'll reopen it if it doesn't actually fix the problem for some reason :)
msg186674 - (view)	Author: Zachary Ware (zach.ware) *	Date: 2013-04-12 19:51
Buildbots look happy (with test_getpass, anyway) and my machine is happy too. Thanks for the commit :)