Issue 17767: Fix test discovery for test_locale.py (original) (raw)

Created on 2013-04-16 19:51 by zach.ware, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg187117 - (view)	Author: Zachary Ware (zach.ware) *	Date: 2013-04-16 19:51
This one actually had Failures rather than Errors; those failures arose from enUS_locale being None because it was being changed in test_main. This patch attempts to fix things by adapting get_enUS_locale() to return a tuple of a suitable setting for enUS_locale and a reason for skipping the tests that were formerly ignored if enUS_locale was None.
msg191387 - (view)	Author: Zachary Ware (zach.ware) *	Date: 2013-06-18 03:09
Looking at this one again, I missed removing the run_unittest import. Here's a new patch.
msg192272 - (view)	Author: Zachary Ware (zach.ware) *	Date: 2013-07-04 05:30
Here's a new patch addressing Serhiy's Rietveld comment. This patch also includes the addition of 'flush=True' to the verbose print in BaseLocalizedTest.setUp to make output look a little nicer.
msg193221 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-07-17 10:27
New changeset 3b883491a5f2 by Serhiy Storchaka in branch '3.3': Issue #17767: test_locale now works with unittest test discovery. http://hg.python.org/cpython/rev/3b883491a5f2 New changeset 60e72210683c by Serhiy Storchaka in branch 'default': Issue #17767: test_locale now works with unittest test discovery. http://hg.python.org/cpython/rev/60e72210683c
msg193223 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2013-07-17 11:36
I combined two last Zachary's patches and added more robust locale test cleanup (old locale now restored even when print() in setUp() will failed). Thank you for your patch Zachary.