Issue 18150: Duplicate test inside TestSingleDispatch (original) (raw)

Issue18150

Created on 2013-06-06 15:18 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_mro.diff vajrasky,2013-06-07 05:58 review
Messages (4)
msg190717 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-06-06 15:18
There is a duplicate test inside TestSingleDispatch in file Lib/test/test_functools.py. The method test_mro and test_classic_classes are not different at all.
msg190735 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-06-07 05:58
I think to test the mro case, we have to test the multiple inheritance with the same ancestor case. Attached my guess of the correct test should be.
msg190775 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-06-07 20:26
New changeset a16bebe653b1 by Łukasz Langa in branch 'default': Fixed #18150: duplicate test inside TestSingleDispatch http://hg.python.org/cpython/rev/a16bebe653b1
msg190776 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2013-06-07 20:29
Good catch. Thanks for the patch, Vajrasky.
History
Date User Action Args
2022-04-11 14:57:46 admin set github: 62350
2013-06-07 20:29:01 lukasz.langa set status: open -> closedassignee: lukasz.langaresolution: fixedmessages: +
2013-06-07 20:26:30 python-dev set nosy: + python-devmessages: +
2013-06-07 05:58:56 vajrasky set files: + test_mro.diffmessages: +
2013-06-07 05:56:34 vajrasky set files: - duplicate_test_for_testsingledispatch.diff
2013-06-06 15🔞12 vajrasky create