Issue 18322: test_stat nits - Python tracker (original ) (raw ) This issue has been migrated to GitHub: https://github.com/python/cpython/issues/62522
classification
process
Created on 2013-06-28 09:54 by pitrou , last changed 2022-04-11 14:57 by admin . This issue is now closed .
Messages (8)
msg191985 - (view)
Author: Antoine Pitrou (pitrou) *
Date: 2013-06-28 09:54
Patch with small fixes and improvements to test_stat.
msg191996 - (view)
Author: Christian Heimes (christian.heimes) *
Date: 2013-06-28 15:14
I wish the loader would ignore all test classes with a leading underscore or would gain another way to mark a test class as abstract. The mixin approach looks ugly and prohibits tab completion in my IDE.
msg192001 - (view)
Author: Antoine Pitrou (pitrou) *
Date: 2013-06-28 15:42
> I wish the loader would ignore all test classes with a leading > underscore or would gain another way to mark a test class as > abstract. The mixin approach looks ugly and prohibits tab completion > in my IDE. I don't really understand what makes mixins "ugly". I'm sorry about your IDE :-)
msg192004 - (view)
Author: Christian Heimes (christian.heimes) *
Date: 2013-06-28 16:44
Ask your Java buddies about mixins. :) Go ahead and submit the patch.
msg192016 - (view)
Author: Terry J. Reedy (terry.reedy) *
Date: 2013-06-28 20:00
While you are at it, should you just replace test_main with unittest.main?
msg192017 - (view)
Author: STINNER Victor (vstinner) *
Date: 2013-06-28 20:15
> The mixin approach looks ugly and prohibits tab completion in my IDE. It is a common practice in Python, especially in tests.
msg192031 - (view)
Author: Roundup Robot (python-dev)
Date: 2013-06-29 10:59
New changeset f3f38c84aebc by Antoine Pitrou in branch 'default': Issue #18322 : fix some test_stat nits. http://hg.python.org/cpython/rev/f3f38c84aebc
msg192032 - (view)
Author: Antoine Pitrou (pitrou) *
Date: 2013-06-29 10:59
Committed with unittest.main(). Thanks for the comments.
History
Date
User
Action
Args
2022-04-11 14:57:47
admin
set
github: 62522
2013-06-29 10:59:27
pitrou
set
status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved
2013-06-29 10:59:05
python-dev
set
nosy: + python-dev messages: +
2013-06-28 20:15:49
vstinner
set
nosy: + vstinner messages: +
2013-06-28 20:00:30
terry.reedy
set
nosy: + terry.reedy messages: +
2013-06-28 19:30:00
serhiy.storchaka
set
nosy: + zach.ware
2013-06-28 19:28:14
serhiy.storchaka
set
nosy: + serhiy.storchaka
2013-06-28 16:44:06
christian.heimes
set
messages: +
2013-06-28 15:42:55
pitrou
set
messages: +
2013-06-28 15:14:48
christian.heimes
set
messages: +
2013-06-28 09:54:55
pitrou
create