Issue 18357: add tests for dictview set difference operations (original) (raw)

Issue18357

Created on 2013-07-04 11:33 by frasertweedale, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (6)
msg192285 - (view)	Author: Fraser Tweedale (frasertweedale)	Date: 2013-07-04 11:33
The Python documentation states that set-like dictionary view objects support set difference (-), however, this behaviour is untested. Add some tests for this behaviour. (This issue was discovered because PyPy doesn't support (-) for dictviews, yet they claimed to pass the test suite. Well, they did pass it ^_^
msg192289 - (view)	Author: Fraser Tweedale (frasertweedale)	Date: 2013-07-04 13:11
and here's a patch for python3 (the earlier patch is for the 2.7 branch).
msg192341 - (view)	Author: Éric Araujo (eric.araujo) *	Date: 2013-07-05 18:51
Looks good to me.
msg192347 - (view)	Author: Eric Snow (eric.snow) *	Date: 2013-07-05 19:03
Same here.
msg194695 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-08-08 17:13
New changeset 0152152b09d0 by Ezio Melotti in branch '2.7': #18357: add tests for dictview set difference. Patch by Fraser Tweedale. http://hg.python.org/cpython/rev/0152152b09d0 New changeset 8b557ef46d7c by Ezio Melotti in branch '3.3': #18357: add tests for dictview set difference. Patch by Fraser Tweedale. http://hg.python.org/cpython/rev/8b557ef46d7c New changeset 4db3d3d5815c by Ezio Melotti in branch 'default': #18357: merge with 3.3. http://hg.python.org/cpython/rev/4db3d3d5815c
msg194696 - (view)	Author: Ezio Melotti (ezio.melotti) *	Date: 2013-08-08 17:14
Fixed, thanks for the report and the patch!