Issue 18377: Python Launcher code cleanup (original) (raw)

Issue18377

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/62577

classification

Title: Python Launcher code cleanup
Type: compile error Stage: resolved
Components: Versions: Python 3.3, Python 3.4, Python 2.7

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ronaldoussoren Nosy List: ned.deily, python-dev, ronaldoussoren
Priority: normal Keywords: patch

Created on 2013-07-06 11:45 by ronaldoussoren, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
cleanup-pythonlauncher-full.txt ronaldoussoren,2013-07-06 11:45 review
Messages (4)
msg192417 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2013-07-06 11:45
While working on a Python Launcher issue (#12990) I noticed some compiler warnings for Python Launcher. The attached patch removes those warnings, and cleans up some indentation issues. Ned: do you have an opinion on applying this to the 3.3 and 2.7 branches? I'd prefer to backport to keep the code base the same (especially because there are no functional changes)
msg192517 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2013-07-07 07:36
LGTM. I think it is best to eliminate the warnings everywhere so I'd apply it to all branches.
msg192518 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-07-07 07:50
New changeset 5d41ebc79738 by Ronald Oussoren in branch '2.7': Issue #18377: Code cleanup in Python Launcher http://hg.python.org/cpython/rev/5d41ebc79738
msg192519 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-07-07 07:54
New changeset 738cba2bf849 by Ronald Oussoren in branch '3.3': Issue #18377: Code cleanup in Python Launcher http://hg.python.org/cpython/rev/738cba2bf849 New changeset d7a59e6f48df by Ronald Oussoren in branch 'default': (3.3->default) Issue #18377: Code cleanup in Python Launcher http://hg.python.org/cpython/rev/d7a59e6f48df
History
Date User Action Args
2022-04-11 14:57:47 admin set github: 62577
2013-07-07 07:55:06 ronaldoussoren set status: open -> closedresolution: fixedstage: commit review -> resolved
2013-07-07 07:54:23 python-dev set messages: +
2013-07-07 07:50:22 python-dev set nosy: + python-devmessages: +
2013-07-07 07:36:11 ned.deily set messages: +
2013-07-06 11:45:03 ronaldoussoren create