| msg192771 - (view) |
Author: Brett Cannon (brett.cannon) *  |
Date: 2013-07-09 19:32 |
| Importlib has ended up with a mixed use of single and double quotes. Should clean it up to be consistent. |
|
|
| msg192775 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2013-07-09 20:13 |
| Do you mean in .c and .py files, or in error messages? |
|
|
| msg192777 - (view) |
Author: Brett Cannon (brett.cannon) * |
Date: 2013-07-09 20:22 |
| String constants in importlib/_bootstrap.py; pylint noticed the discrepancy. |
|
|
| msg192887 - (view) |
Author: Madison May (madison.may) * |
Date: 2013-07-11 19:16 |
| Patch using all single quotes for string literals, except for 3 cases of double quoted strings that contain single quotes (I thought it was probably preferable to escaping the single quotes). |
|
|
| msg192888 - (view) |
Author: Madison May (madison.may) * |
Date: 2013-07-11 19:17 |
| Patch using all double quotes. Take your pick :) |
|
|
| msg192891 - (view) |
Author: Brett Cannon (brett.cannon) * |
Date: 2013-07-11 19:38 |
| I prefer single quotes (easier to type =) and yes, using double quotes instead of escaping is preferred. When I have a chance I will take a look at the patch. |
|
|
| msg192935 - (view) |
Author: Brett Cannon (brett.cannon) * |
Date: 2013-07-12 12:28 |
| Why the stage change? I set it to commit review on purpose as I already did a cursory check and it was fine. I have only have one more paranoid check before do the commit myself. I purposely didn't set patch review as I didn't want anyone wasting their time doing one as I'm going to do the one more and that's enough for committal. |
|
|
| msg192943 - (view) |
Author: Roundup Robot (python-dev)  |
Date: 2013-07-12 15:04 |
| New changeset 33d379c2bb79 by Brett Cannon in branch 'default': Issue #18415: Normalize what type of quotes are used with string http://hg.python.org/cpython/rev/33d379c2bb79 |
|
|
| msg192944 - (view) |
Author: Brett Cannon (brett.cannon) * |
Date: 2013-07-12 15:05 |
| Thanks for the path, Madison! I also cleaned up the instances using double quotes since it was because I was faking the use of a string's repr instead of explicitly using {!r}. |
|
|
| msg192949 - (view) |
Author: Madison May (madison.may) * |
Date: 2013-07-12 15:51 |
| No problem, Brett. Glad to hear you could get rid of those few last pesky double quotes. I'm partial to the single quotes as well. |
|
|