Issue 18453: There are unused variables inside DateTimeTestCase class in test_xmlrpc.py (original) (raw)
Issue18453
Created on 2013-07-14 15:58 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | |||
|---|---|---|---|
| File name | Uploaded | Description | Edit |
| fix_DateTimeTestCase.txt | vajrasky,2013-07-14 15:58 | Fix for unit test inside DateTimeTestCase class in test_xmlrpc.py | review |
| fix_DateTimeTestCase_using_mock_object.txt | vajrasky,2013-07-14 16:33 | Fix for unit test inside DateTimeTestCase class in test_xmlrpc.py using mock object | review |
| Messages (5) | ||
|---|---|---|
| msg193059 - (view) | Author: Vajrasky Kok (vajrasky) * | Date: 2013-07-14 15:58 |
| Attached the menial fix to unit test in test_xmlrpc.py. | ||
| msg193061 - (view) | Author: Vajrasky Kok (vajrasky) * | Date: 2013-07-14 16:33 |
| Okay, instead of using computer timer, I use mock object instead. | ||
| msg193485 - (view) | Author: Alexander Belopolsky (belopolsky) *  |
Date: 2013-07-22 02:31 |
| LGTM | ||
| msg194805 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2013-08-10 15:37 |
| New changeset 28c756093a63 by Ezio Melotti in branch '3.3': #18453: fix unused variables in test_xmlrpc. Patch by Vajrasky Kok. http://hg.python.org/cpython/rev/28c756093a63 New changeset 9f7581816890 by Ezio Melotti in branch 'default': #18453: merge with 3.3. http://hg.python.org/cpython/rev/9f7581816890 | ||
| msg194806 - (view) | Author: Ezio Melotti (ezio.melotti) * |
Date: 2013-08-10 15:38 |
| Fixed, thanks for the report and the patch! |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:48 | admin | set | github: 62653 |
| 2013-08-10 15:38:22 | ezio.melotti | set | status: open -> closedtype: enhancementassignee: ezio.melottiversions: + Python 3.3nosy: + ezio.melottimessages: + resolution: fixedstage: resolved |
| 2013-08-10 15:37:56 | python-dev | set | nosy: + python-devmessages: + |
| 2013-07-22 02:31:00 | belopolsky | set | messages: + |
| 2013-07-19 21:19:34 | terry.reedy | set | nosy: + belopolsky |
| 2013-07-14 16:33:02 | vajrasky | set | files: + fix_DateTimeTestCase_using_mock_object.txtmessages: + |
| 2013-07-14 15:58:59 | vajrasky | create |