Issue 18465: There are unused variables and unused import in Lib/test/test_minidom.py (original) (raw)
Created on 2013-07-15 16:00 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.
Files | |||
---|---|---|---|
File name | Uploaded | Description | Edit |
fix_for_unused_variables_and_unused_import_in_test_minidom.txt | vajrasky,2013-07-15 16:00 | Fix for unused variables and unused import in test_minidom.py file | review |
Messages (3) | ||
---|---|---|
msg193113 - (view) | Author: Vajrasky Kok (vajrasky) * | Date: 2013-07-15 16:00 |
The unit test file imports verbose from test.support, but it never used it. The child2 variable inside testRemoveAttributeNode is not used. The doc variable inside testHasChildNodes is not used. Attached the menial fix for this unit test. | ||
msg194803 - (view) | Author: Roundup Robot (python-dev) ![]() |
Date: 2013-08-10 15:31 |
New changeset 4daa18b5ad49 by Ezio Melotti in branch '3.3': #18465: fix unused variables in test_minidom. Patch by Vajrasky Kok. http://hg.python.org/cpython/rev/4daa18b5ad49 New changeset 47770b408321 by Ezio Melotti in branch 'default': #18465: merge with 3.3. http://hg.python.org/cpython/rev/47770b408321 | ||
msg194804 - (view) | Author: Ezio Melotti (ezio.melotti) * ![]() |
Date: 2013-08-10 15:32 |
Fixed, thanks for the report and the patch! |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-11 14:57:48 | admin | set | github: 62665 |
2013-08-10 15:32:20 | ezio.melotti | set | status: open -> closedtype: enhancementassignee: ezio.melottiversions: + Python 3.3nosy: + ezio.melottimessages: + resolution: fixedstage: resolved |
2013-08-10 15:31:49 | python-dev | set | nosy: + python-devmessages: + |
2013-07-15 16:00:18 | vajrasky | create |