Issue 18571: Implementation of the PEP 446: non-inheritable file descriptors (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/62771

classification

process

Created on 2013-07-27 15:28 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

| Repositories containing patches | | | | | ------------------------------------------------------------------------------------------------------ | | | | | http://hg.python.org/features/pep-446 | | | |

Messages (8)
msg193786 - (view)	Author: STINNER Victor (vstinner) *	Date: 2013-07-27 15:47
Implementation of the PEP 446.
msg194917 - (view)	Author: STINNER Victor (vstinner) *	Date: 2013-08-12 01:19
+ if (make_inheritable(py_fds_to_keep) < 0) + goto error; + /* errpipe_write is part of py_fds_to_keep. It must be closed at + exec(), but kept open in the child process until exec() is called. */ + if (_Py_set_inheritable((int)errpipe_write, 0, NULL) < 0) + goto error; make_inheritable() should ignore errpipe_write, instead of changing twice the inheritable flag of errpipe_write.
msg195674 - (view)	Author: STINNER Victor (vstinner) *	Date: 2013-08-19 21:41
> make_inheritable() should ignore errpipe_write, instead of changing twice the inheritable flag of errpipe_write. Done in the last patch (00df7fc6d2ef.diff).
msg195930 - (view)	Author: STINNER Victor (vstinner) *	Date: 2013-08-22 22:55
I tested 17211acb65b1.diff on my x86_64 VMs: Linux: Linux-3.9.4-200.fc18.x86_64-x86_64-with-fedora-18-Spherical_Cow => 358 tests OK. OpenIndiana: Solaris-2.11-i86pc-i386-32bit-ELF => 3 tests failed: test_locale test_tcl test_uuid -- none of these failures are related to the PEP and also occurs in default Mac OS X: Darwin-10.8.0-i386-64bit => 352 tests OK. FreeBSD: FreeBSD-9.1-RELEASE-amd64-64bit-ELF => 351 tests OK. Windows: Windows-7-6.1.7601-SP1 => 329 tests OK So it works on all (tested) platforms ;-)
msg196329 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-08-27 23:20
New changeset ef889c3d5dc6 by Victor Stinner in branch 'default': Issue #18571: Implementation of the PEP 446: file descriptors and file handles http://hg.python.org/cpython/rev/ef889c3d5dc6
msg196349 - (view)	Author: Charles-François Natali (neologix) *	Date: 2013-08-28 05:44
14.1 --- a/Lib/multiprocessing/util.py 14.2 +++ b/Lib/multiprocessing/util.py 14.13 # 14.14 # Return pipe with CLOEXEC set on fds 14.15 # 14.16 +# Deprecated: os.pipe() creates non-inheritable file descriptors 14.17 +# since Python 3.4 14.18 +# 14.19 14.20 def pipe(): 14.21 - import _posixsubprocess 14.22 - return _posixsubprocess.cloexec_pipe() 14.23 + return os.pipe() I guess you could remove util.pipe() altogether: it wasn't part of the public API.
msg196355 - (view)	Author: STINNER Victor (vstinner) *	Date: 2013-08-28 07:37
> I guess you could remove util.pipe() altogether: it wasn't part of the public API. Ah yes, I wanted to create an issue for that but I forgot. Here you have: issue #18865.
msg196715 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-09-01 08:22
New changeset c27527dce71e by Victor Stinner in branch 'default': Issue #18571: Merge duplicate test code http://hg.python.org/cpython/rev/c27527dce71e