original ) (raw )Created on 2013-08-06 13:20 by eli.bendersky , last changed 2022-04-11 14:57 by admin . This issue is now closed .
Messages (9)
msg194542 - (view) Author: Eli Bendersky (eli.bendersky) *
Date: 2013-08-06 13:20
docs.python.org/dev/c-api/module.html Currently doesn't say much about m_size, except that setting it to -1 means "no memory needed". m_size == -1 has a much more important use that is not documented: it signals the import machinery that the module should not be ever re-initialized. This has to be documented explicitly.
msg194548 - (view) Author: Eli Bendersky (eli.bendersky) *
Date: 2013-08-06 14:06
Here's a documentation patch generated for 3.3
msg194550 - (view) Author: Antoine Pitrou (pitrou) *
Date: 2013-08-06 14:16
Looks good to me, thanks.
msg194605 - (view) Author: Roundup Robot (python-dev)
Date: 2013-08-07 12:54
New changeset 698fd628b001 by Eli Bendersky in branch '3.3': Issue #18668 : Properly document setting m_size in PyModuleDef http://hg.python.org/cpython/rev/698fd628b001 New changeset 9877c25d9556 by Eli Bendersky in branch 'default': Closing #18668 : Properly document setting m_size in PyModuleDef http://hg.python.org/cpython/rev/9877c25d9556
msg194606 - (view) Author: Eli Bendersky (eli.bendersky) *
Date: 2013-08-07 12:55
Thanks for the review!
msg194609 - (view) Author: Alyssa Coghlan (ncoghlan) *
Date: 2013-08-07 13:32
I thought setting m_size to zero was for "No per module state, but reinitialization is fine"? Does that not work? (I haven't actually tried it)
msg194672 - (view) Author: Eli Bendersky (eli.bendersky) *
Date: 2013-08-08 13:36
Nick, you're right - m_size=0 is a valid value. How about the attached patch?
msg194687 - (view) Author: Alyssa Coghlan (ncoghlan) *
Date: 2013-08-08 15:38
Looks good to me.
msg194791 - (view) Author: Roundup Robot (python-dev)
Date: 2013-08-10 12:58
New changeset f55ba27776d4 by Eli Bendersky in branch '3.3': Issue #18668 : Further clarify m_size setting for non-negative values http://hg.python.org/cpython/rev/f55ba27776d4 New changeset d43435e82e21 by Eli Bendersky in branch 'default': Issue #18668 : Further clarify m_size setting for non-negative values http://hg.python.org/cpython/rev/d43435e82e21
History
Date
User
Action
Args
2022-04-11 14:57:49
admin
set
github: 62868
2013-08-10 12:58:45
python-dev
set
messages: +
2013-08-08 15:38:11
ncoghlan
set
messages: +
2013-08-08 13:36:45
eli.bendersky
set
files: + issue18668.msize-fix.patch messages: +
2013-08-07 13:32:30
ncoghlan
set
messages: +
2013-08-07 12:55:54
eli.bendersky
set
status: open -> closedresolution: fixedstage: needs patch -> resolved
2013-08-07 12:55:25
eli.bendersky
set
status: closed -> openresolution: fixed -> (no value)messages: + stage: resolved -> needs patch
2013-08-07 12:54:57
python-dev
set
status: open -> closednosy: + python-dev messages: + resolution: fixedstage: needs patch -> resolved
2013-08-06 14:16:48
pitrou
set
nosy: + pitrou messages: +
2013-08-06 14:06:12
eli.bendersky
set
files: + issue18668.doc.1.patch keywords: + patch messages: +
2013-08-06 13:20:58
eli.bendersky
set
nosy: + loewis
2013-08-06 13:20:46
eli.bendersky
create
