| msg194850 - (view) |
Author: Févry Thibault (iwontbecreative) * |
Date: 2013-08-10 23:45 |
| In issue 18466 I had said I was planning to write a tool that checks python source code to see if they are spelling mistakes in comments/strings. As it was said there, the big issue was the fact that python has so many non-english words and that docstrings often had variable names in them, so I had to work arround the issue and add a personal word list. I only applied the tool to Lib/*.py yet, as it takes some time to check false-positives and I didn't want to end with patches too big to be reviewed. |
|
|
| msg194851 - (view) |
Author: Févry Thibault (iwontbecreative) * |
Date: 2013-08-10 23:48 |
| Note that I am not a very good python programmer so the attached script may look ugly to you, but it works. |
|
|
| msg194852 - (view) |
Author: Févry Thibault (iwontbecreative) * |
Date: 2013-08-10 23:48 |
| And here is a python_words.txt so you have to press enter less times :) |
|
|
| msg194881 - (view) |
Author: Mark Dickinson (mark.dickinson) *  |
Date: 2013-08-11 10:02 |
| Thanks for the patch. I don't think there's a strict policy about using American spellings in the source; I think spellings like 'behaviour' and 'grey' should be left alone. |
|
|
| msg194884 - (view) |
Author: Févry Thibault (iwontbecreative) * |
Date: 2013-08-11 10:15 |
| > I don't think there's a strict policy about using American spellings in the source; I think spellings like 'behaviour' and 'grey' should be left alone. I didn't really know whether to change them or not and did not find an answer in the devguide (Might be worth documenting it ?) so I decided to change it :/. |
|
|
| msg194885 - (view) |
Author: Ezio Melotti (ezio.melotti) * |
Date: 2013-08-11 10:19 |
| Both AE and BE are OK, as long as each document is internally consistent. For new documents I think AE is preferred, but not forced. |
|
|
| msg194891 - (view) |
Author: Févry Thibault (iwontbecreative) * |
Date: 2013-08-11 12:25 |
| Updated the patch to no longer change BE to AE and fixed two mistakes in my correction. |
|
|
| msg194892 - (view) |
Author: Mark Dickinson (mark.dickinson) * |
Date: 2013-08-11 12:31 |
| Thanks for the update. All the changes in the updated patch look good to me. |
|
|
| msg195417 - (view) |
Author: Ezio Melotti (ezio.melotti) * |
Date: 2013-08-16 20:47 |
| See also #18741. |
|
|
| msg195433 - (view) |
Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-08-16 22:07 |
| I'm not spelling expert Antoine. :-) |
|
|
| msg195460 - (view) |
Author: Roundup Robot (python-dev)  |
Date: 2013-08-17 12:54 |
| New changeset d234dd21374a by Ezio Melotti in branch '2.7': #18705: fix a number of typos. Patch by Févry Thibault. http://hg.python.org/cpython/rev/d234dd21374a New changeset e07f104133d5 by Ezio Melotti in branch '3.3': #18705: fix a number of typos. Patch by Févry Thibault. http://hg.python.org/cpython/rev/e07f104133d5 New changeset a9ee869cae40 by Ezio Melotti in branch 'default': #18705: merge with 3.3. http://hg.python.org/cpython/rev/a9ee869cae40 |
|
|
| msg195461 - (view) |
Author: Ezio Melotti (ezio.melotti) * |
Date: 2013-08-17 12:56 |
| Fixed, thanks for the report and the patch! |
|
|