Issue 18871: Be more stringent about the test suite (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/63071

classification

process

Created on 2013-08-28 19:32 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (7)
msg196405 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2013-08-28 19:32
Here is a proposal to make the devguide more precise and explicit about needing to run the entire test suite before committing a change.
msg196410 - (view)	Author: R. David Murray (r.david.murray) *	Date: 2013-08-28 19:51
Looks OK to me. Do we want to also recommend more explicitly that the tests be run with -uall?
msg196412 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2013-08-28 20:16
I don't know. I wouldn't insist too much on -uall, because generally it won't find anything more (except for network tests, perhaps).
msg196426 - (view)	Author: Alyssa Coghlan (ncoghlan) *	Date: 2013-08-28 21:36
Looks good to me. I think it's OK to leave the optional resources in the set of things covered by the buildbots rather than expecting them to always be run in pre-commit testing.
msg196427 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-08-28 21:51
New changeset a62bb0481ac9 by Antoine Pitrou in branch 'default': Issue #18871: make it more explicit that the test suite should be run before committing http://hg.python.org/devguide/rev/a62bb0481ac9
msg196428 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2013-08-28 21:52
Thanks for allowing me to be lazy, Nick :-)
msg196430 - (view)	Author: Alyssa Coghlan (ncoghlan) *	Date: 2013-08-28 22:12
The fact I don't run the tests with - uall before committing had nothing to do with it whatsoever. Nope. Nothing at all ;)