Issue 18904: Unnecessary test in file descriptor inheritance test (original) (raw)

Issue18904

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/63104

classification

process

Created on 2013-09-02 03:39 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg196768 - (view)	Author: Vajrasky Kok (vajrasky) *	Date: 2013-09-02 03:39
In Lib/test/test_os.py in class FDInheritanceTests, we have an unnecessary test, which is test_set_inheritable. What test_set_inheritable tests is already being covered by test_get_inheritable. Also, I think test_get_inheritable should be renamed to test_set_inheritable. Please, see the patch to see what I mean.
msg197237 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-09-08 09:48
New changeset b13cec63b495 by Victor Stinner in branch 'default': Issue #18904: Improve os.get/set_inheritable() tests http://hg.python.org/cpython/rev/b13cec63b495
msg197238 - (view)	Author: STINNER Victor (vstinner) *	Date: 2013-09-08 09:48
Thanks for the report and the patch. I removed the duplicate test, but I also added new tests using fcntl and FD_CLOEXEC.
msg197240 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-09-08 09:53
New changeset b7f6f6f59e91 by Victor Stinner in branch 'default': Issue #18904: test_socket: add inheritance tests using fcntl and FD_CLOEXEC http://hg.python.org/cpython/rev/b7f6f6f59e91
msg197257 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-09-08 12:14
New changeset aea58e1cae75 by Victor Stinner in branch 'default': Issue #18904: test_os and test_socket use unittest.skipIf() to check if fcntl http://hg.python.org/cpython/rev/aea58e1cae75