original ) (raw )Created on 2013-09-06 09:12 by arigo , last changed 2022-04-11 14:57 by admin . This issue is now closed .
Messages (8)
msg197060 - (view) Author: Armin Rigo (arigo) *
Date: 2013-09-06 09:12
Found a minor mistake in test_set.py. Patch attached.
msg197100 - (view) Author: Terry J. Reedy (terry.reedy) *
Date: 2013-09-06 19:25
The typo causes 1 test to run 5 times instead of 5 tests 1 each. After fix, all pass on Win7, 3.4.0a1 (where fix is on line 1675 instead of 1618).
msg197101 - (view) Author: Tim Peters (tim.peters) *
Date: 2013-09-06 19:41
The fix is obviously correct ;-) - so what next? Armin & Terry, I don't know whether you have commit privileges. If you don't, assign it to me and I'll commit it. Removed 3.5 from the Versions list and added 3.3 and 3.4.
msg197104 - (view) Author: Roundup Robot (python-dev)
Date: 2013-09-06 20:43
New changeset b6059bac8a9c by Tim Peters in branch '3.3': Issue 18944 : fix a 1-character typo in test_set.py. http://hg.python.org/cpython/rev/b6059bac8a9c New changeset 4b64166d5abb by Tim Peters in branch 'default': Merge 3.3 into default. http://hg.python.org/cpython/rev/4b64166d5abb
msg197126 - (view) Author: Terry J. Reedy (terry.reedy) *
Date: 2013-09-07 01:55
Just to answer, anyone with Python snake has commit privileges of some sort but may not be setup to commit to cpython. I suspect Armin found this while review the test for pypy. I focus mostly on Idle, but on better days, will do little commits like this.
msg197127 - (view) Author: Tim Peters (tim.peters) *
Date: 2013-09-07 02:06
Right, I should have asked specifically about cpython commit privs ;-) Thanks for expounding!
msg217197 - (view) Author: Berker Peksag (berker.peksag) *
Date: 2014-04-26 13:27
The same typo also needs to be fixed in the 2.7 branch: http://hg.python.org/cpython/file/2.7/Lib/test/test_set.py#l1618
msg217206 - (view) Author: Roundup Robot (python-dev)
Date: 2014-04-26 17:56
New changeset de6047ea33e6 by Terry Jan Reedy in branch '2.7': Issue #18944 : backport typo fix http://hg.python.org/cpython/rev/de6047ea33e6
History
Date
User
Action
Args
2022-04-11 14:57:50
admin
set
github: 63144
2014-04-26 17:57:27
terry.reedy
set
status: open -> closedtype: behaviorresolution: fixedstage: needs patch -> resolved
2014-04-26 17:56:48
python-dev
set
messages: +
2014-04-26 17:51:43
terry.reedy
set
assignee: tim.peters -> terry.reedy
2014-04-26 13:27:45
berker.peksag
set
status: closed -> openversions: + Python 2.7nosy: + berker.peksag messages: + resolution: fixed -> (no value)stage: resolved -> needs patch
2013-09-07 02:06:06
tim.peters
set
messages: +
2013-09-07 01:55:30
terry.reedy
set
messages: +
2013-09-06 20:43:59
tim.peters
set
status: open -> closedresolution: fixedstage: resolved
2013-09-06 20:43:26
python-dev
set
nosy: + python-dev messages: +
2013-09-06 20:34:27
arigo
set
assignee: tim.peters
2013-09-06 19:42:06
tim.peters
set
components: + Tests, - Interpreter Core
2013-09-06 19:41:47
tim.peters
set
nosy: + tim.peters messages: + versions: + Python 3.3, Python 3.4, - Python 3.5
2013-09-06 19:25:27
terry.reedy
set
nosy: + rhettinger , terry.reedy messages: +
2013-09-06 09:12:51
arigo
create
