Issue 19405: Fix outdated comments in the _sre module (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/63604

classification

Title: Fix outdated comments in the _sre module
Type: enhancement Stage: resolved
Components: Documentation, Regular Expressions Versions: Python 3.3, Python 3.4, Python 2.7

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: docs@python, ezio.melotti, mrabarnett, pitrou, python-dev, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2013-10-26 08:40 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
sre_comments.patch serhiy.storchaka,2013-10-26 08:40 review
Messages (4)
msg201330 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-10-26 08:40
The _sre module contains comments which refers to 16-bit SRE_CODE. Now SRE_CODE is 32-bit. Antoine partially reviewed this change in .
msg201393 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2013-10-26 20:25
Looks good to me, except that it probably shouldn't apply to 2.7 (does it?).
msg201395 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-10-26 20:41
In 2.7 SRE_CODE is 32-bit too (since ). Only last chunk in Lib/sre_compile.py patch shouldn't apply to 2.7.
msg201418 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-10-27 06:09
New changeset b7f71babc622 by Serhiy Storchaka in branch '2.7': Issue #19405: Fixed outdated comments in the _sre module. http://hg.python.org/cpython/rev/b7f71babc622 New changeset 220e3e40d176 by Serhiy Storchaka in branch '3.3': Issue #19405: Fixed outdated comments in the _sre module. http://hg.python.org/cpython/rev/220e3e40d176 New changeset d6f427f94d85 by Serhiy Storchaka in branch 'default': Issue #19405: Fixed outdated comments in the _sre module. http://hg.python.org/cpython/rev/d6f427f94d85
History
Date User Action Args
2022-04-11 14:57:52 admin set github: 63604
2013-10-27 06:25:08 serhiy.storchaka set status: open -> closedassignee: docs@python -> serhiy.storchakaresolution: fixedstage: patch review -> resolved
2013-10-27 06:09:34 python-dev set nosy: + python-devmessages: +
2013-10-26 20:41:39 serhiy.storchaka set messages: +
2013-10-26 20:25:05 pitrou set messages: +
2013-10-26 08:40:19 serhiy.storchaka create