Issue 1949: test_ntpath.py converted to unittest (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/46241

classification

Title: test_ntpath.py converted to unittest
Type: enhancement Stage:
Components: Tests Versions: Python 2.6

process

Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: Nosy List: amaury.forgeotdarc, benjamin.peterson, christian.heimes, giampaolo.rodola, pavel.vinogradov
Priority: normal Keywords: easy, patch

Created on 2008-01-27 22:19 by giampaolo.rodola, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_ntpath.diff giampaolo.rodola,2008-01-27 22:19 rewrite test_ntpath.py for using unittest
test_ntpath.py giampaolo.rodola,2008-01-27 22:20 rewrite test_ntpath.py for using unittest (modified py file)
test_ntpath.diff giampaolo.rodola,2008-02-06 19:08 Diff file generated with svn diff
Messages (6)
msg61750 - (view) Author: Giampaolo Rodola' (giampaolo.rodola) * (Python committer) Date: 2008-01-27 22:19
Since I noticed that test_ntpath.py (unlike test_genericpath.py, test_macpath.py and test_posixpath.py) does NOT use unittest for doing tests I tried to rewrite it. The patch in attachment does that leaving the original tests unchanged. Tested successfully by having used python 2.6 (current trunk) on Windows XP and Linux Ubuntu.
msg61752 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2008-01-27 22:28
The patch looks fine but I've no time to review it properly.
msg62118 - (view) Author: Giampaolo Rodola' (giampaolo.rodola) * (Python committer) Date: 2008-02-06 19:08
The diff file in attachment was generated by using TortoiseSVN and it seems to be different than using "svn diff". The new diff file is in attachment.
msg62745 - (view) Author: Pavel Vinogradov (pavel.vinogradov) * Date: 2008-02-23 15:19
This patch also looks good for me. It convert all test cases and run successfully on latest python trunk (on Linux).
msg68657 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-06-23 23:01
This patch no longer applies cleanly.
msg75787 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2008-11-12 15:19
Done since r61926.
History
Date User Action Args
2022-04-11 14:56:30 admin set github: 46241
2008-11-12 15:19:03 amaury.forgeotdarc set status: open -> closedresolution: accepted -> out of datemessages: + nosy: + amaury.forgeotdarc
2008-06-23 23:01:54 benjamin.peterson set nosy: + benjamin.petersonmessages: +
2008-02-23 15:19:36 pavel.vinogradov set nosy: + pavel.vinogradovmessages: +
2008-02-06 19:08:02 giampaolo.rodola set files: + test_ntpath.diffmessages: +
2008-01-27 22:34:49 giampaolo.rodola set title: test_ntpath.py rewriting -> test_ntpath.py converted to unittest
2008-01-27 22:28:14 christian.heimes set nosy: + christian.heimesmessages: + priority: normaltype: enhancementkeywords: + patch, easyresolution: accepted
2008-01-27 22:20:35 giampaolo.rodola set files: + test_ntpath.py
2008-01-27 22:19:44 giampaolo.rodola create