Issue 19579: test_asyncio: test__run_once timings should be relaxed (original) (raw)

Issue19579

Created on 2013-11-14 01:00 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg202813 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-11-14 01:00
On Windows, the monotonic timer has a resolution of 15 ms in the worst case. The timing should accept a greater error. http://buildbot.python.org/all/builders/x86%20XP-4%203.x/builds/9547/steps/test/logs/stdio ====================================================================== FAIL: test__run_once (test.test_asyncio.test_base_events.BaseEventLoopTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\lib\test\test_asyncio\test_base_events.py", line 184, in test__run_once self.assertTrue(9.99 < t < 10.1, t) AssertionError: False is not true : 9.989999999990687
msg202818 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-11-14 04:18
New changeset f91550e7e2b7 by Guido van Rossum in branch 'default': asyncio: Relax timing requirement. Fixes issue 19579. http://hg.python.org/cpython/rev/f91550e7e2b7
msg204054 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-11-23 17:00
Oh, the problem is now in the opposite direction... Windows clocks don't look to be reliable or the buildbot is very busy :-/ http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/7586/steps/test/logs/stdio ====================================================================== FAIL: test__run_once (test.test_asyncio.test_base_events.BaseEventLoopTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_asyncio\test_base_events.py", line 184, in test__run_once self.assertTrue(9.9 < t < 10.1, t) AssertionError: False is not true : 9.71900000050664
msg204058 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-11-23 17:20
New changeset 085091cb6e4c by Guido van Rossum in branch 'default': Relax timing even more, hopefully again fixes issue 19579. http://hg.python.org/cpython/rev/085091cb6e4c
msg205998 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-12-13 00:35
I didn't see the failure recently, thanks.
History
Date User Action Args
2022-04-11 14:57:53 admin set github: 63778
2013-12-13 00:35:00 vstinner set status: open -> closedresolution: fixedmessages: + components: + Tests
2013-11-23 17:20:23 python-dev set messages: +
2013-11-23 17:00:08 vstinner set status: closed -> openresolution: fixed -> (no value)messages: +
2013-11-14 08:23:52 vstinner set status: open -> closedresolution: fixed
2013-11-14 04🔞01 python-dev set nosy: + python-devmessages: +
2013-11-14 02:06:58 gvanrossum set nosy: + pitrou, ezio.melotti
2013-11-14 02:04:47 gvanrossum link issue19371 superseder
2013-11-14 01:00:00 vstinner create