original ) (raw ) Issue19586
Created on 2013-11-14 17:27 by Gregory.Salvan , last changed 2022-04-11 14:57 by admin . This issue is now closed .
Messages (8)
msg202863 - (view) Author: Gregory Salvan (Gregory.Salvan)
Date: 2013-11-14 17:27
Replace assertEquals by assertEqual and assert_ by assertTrue to remove tests deprecation warning. It's few, but it's a first step to make contributions.
msg202870 - (view) Author: Serhiy Storchaka (serhiy.storchaka) *
Date: 2013-11-14 18:11
See also .
msg202875 - (view) Author: Gregory Salvan (Gregory.Salvan)
Date: 2013-11-14 18:42
Do I suggest the patch to and close this one ?
msg202878 - (view) Author: Serhiy Storchaka (serhiy.storchaka) *
Date: 2013-11-14 20:29
No. Issue16510 enhances tests while your patch fixes bugs. LGTM.
msg203020 - (view) Author: Serhiy Storchaka (serhiy.storchaka) *
Date: 2013-11-16 10:49
Jason just have fixed assertEquals usage in 3.4.
msg203051 - (view) Author: Roundup Robot (python-dev)
Date: 2013-11-16 15:36
New changeset ff471d8526a8 by Jason R. Coombs in branch 'default': Issue #19586 : Update remaining deprecated assertions to their preferred usage. http://hg.python.org/cpython/rev/ff471d8526a8
msg203052 - (view) Author: Jason R. Coombs (jaraco) *
Date: 2013-11-16 15:37
Thanks Gregory for the report and patch. I was unaware of this ticket when I was correcting the deprecation warnings for distutils, so I've just used your patch as a reference and pushed the remaining fixes as you indicated.
msg203056 - (view) Author: Gregory Salvan (Gregory.Salvan)
Date: 2013-11-16 15:58
nice if it helps.
History
Date
User
Action
Args
2022-04-11 14:57:53
admin
set
github: 63785
2013-11-16 15:58:03
Gregory.Salvan
set
messages: +
2013-11-16 15:37:26
jaraco
set
status: open -> closedresolution: fixedmessages: + stage: commit review -> resolved
2013-11-16 15:36:06
python-dev
set
nosy: + python-dev messages: +
2013-11-16 10:49:44
serhiy.storchaka
set
nosy: + jaraco messages: +
2013-11-14 20:29:10
serhiy.storchaka
set
type: compile error -> behaviormessages: + stage: commit review
2013-11-14 18:42:33
Gregory.Salvan
set
messages: + components: + Tests
2013-11-14 18:11:15
serhiy.storchaka
set
nosy: + serhiy.storchaka messages: +
2013-11-14 17:32:02
ezio.melotti
set
assignee: ezio.melotti nosy: + ezio.melotti
2013-11-14 17:29:10
vstinner
set
title: Remove assertEquals and assert_ deprecation warnings -> distutils: Remove assertEquals and assert_ deprecation warnings
2013-11-14 17:27:58
Gregory.Salvan
create
