Issue 19798: tracemalloc: rename "max_size" to "peak_size" in get_traced_memory() result (original) (raw)

Created on 2013-11-26 12:55 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg204470 - (view)	Author: STINNER Victor (vstinner) *	Date: 2013-11-26 12:55
Jim.J.Jewett asked me to replaced "max_size" with "peak_size". It looks like Linux also uses the term "peak" for /proc/pid/status (or sometimes "High Water Mark"). See attached patch.
msg204473 - (view)	Author: STINNER Victor (vstinner) *	Date: 2013-11-26 13:00
@neologix: I would like your opinion first, because you accepted the PEP.
msg204476 - (view)	Author: Charles-François Natali (neologix) *	Date: 2013-11-26 13:37
> STINNER Victor added the comment: > > @neologix: I would like your opinion first, because you accepted the PEP. Well, I'm not a native speaker, but "peak" does sound better than "max" (I'd say the later refers to an externally-enforced limit, contrarily to the former). So the change looks fine, although: """ `(size: int, peak_size: int)`` """ Would maybe be better with: """ `(current: int, peak: int)`` """ no?
msg204610 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-11-27 20:40
New changeset 553144bd7bf1 by Victor Stinner in branch 'default': Close #19798: replace "maximum" term with "peak" in get_traced_memory() http://hg.python.org/cpython/rev/553144bd7bf1
msg204611 - (view)	Author: STINNER Victor (vstinner) *	Date: 2013-11-27 20:41
> no? yes, I also prefer "current" over "size".