| msg204477 - (view) |
Author: Eli Bendersky (eli.bendersky) *  |
Date: 2013-11-26 14:34 |
| Following up from Issue #19673; The initial patch clarifies the use cases of pure vs. concrete paths a bit and adds explicit signatures for the path class constructors (moving the construction discussion under the parent class). Also, IMHO an inheritance diagram from PEP 428 is very relevant and useful. Would you mind if I add a .png for the pathlib rst doc? |
|
|
| msg204502 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2013-11-26 16:54 |
| > Would you mind if I add a .png for the pathlib rst doc? No, it sounds ok to me. |
|
|
| msg204581 - (view) |
Author: Eli Bendersky (eli.bendersky) * |
Date: 2013-11-27 14:09 |
| Attaching a new patch. Hopefully the image will be viewable in the code review tool |
|
|
| msg204582 - (view) |
Author: Eli Bendersky (eli.bendersky) * |
Date: 2013-11-27 14:11 |
| Just in case it isn't: https://dl.dropboxusercontent.com/u/15602400/images/pathlib-inheritance.png |
|
|
| msg204583 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2013-11-27 14:11 |
| > Hopefully the image will be viewable in the code review tool Apparently not :) |
|
|
| msg204587 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2013-11-27 14:21 |
| Could you please attach the picture separatly? |
|
|
| msg204590 - (view) |
Author: Eli Bendersky (eli.bendersky) * |
Date: 2013-11-27 14:37 |
| On Wed, Nov 27, 2013 at 6:21 AM, STINNER Victor <report@bugs.python.org>wrote: > > STINNER Victor added the comment: > > Could you please attach the picture separatly? > > Done |
|
|
| msg204591 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2013-11-27 14:37 |
| Which tool did you use to draw this schema? You may attach also the source if someone would like to modify it in the future. |
|
|
| msg204592 - (view) |
Author: Eli Bendersky (eli.bendersky) * |
Date: 2013-11-27 14:44 |
| > > STINNER Victor added the comment: > > Which tool did you use to draw this schema? You may attach also the source > if someone would like to modify it in the future. > Sorry, but there's no source. I drew it graphically. But since I did it with Google Drive's drawing program, I can just share out a link to the editor - https://docs.google.com/drawings/d/1F8do-1WL1sIGkZuiufcxcpZRtS0w4SwAowq-Uamrwt8/edit?usp=sharing I suppose if someone wants to edit it they can copy the document and do that. |
|
|
| msg204594 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2013-11-27 15:14 |
| You can export the schema as SVG. |
|
|
| msg204668 - (view) |
Author: Eli Bendersky (eli.bendersky) * |
Date: 2013-11-28 14:53 |
| Committed in 90b56ec318b6 |
|
|
