| msg205287 - (view) |
Author: Antony Lee (Antony.Lee) * |
Date: 2013-12-05 11:13 |
| multiprocessing.sharedctypes was not updated after the "q" (c_longlong) and "Q" (c_ulonglong) typecodes were added to the array module (the docs claim that the typecode can be "one character typecode of the kind used by the array module"). The attached patch (just adding an entry to the typecode-to-type dict, as well as some more tests) fixes the issue. |
|
|
| msg298372 - (view) |
Author: Gareth Rees (gdr@garethrees.org) *  |
Date: 2017-07-14 19:24 |
| Patch looks good to me. The test cases are not very systematic (why only int, double, and long long?), but that's not the fault of the patch and shouldn't prevent its being applied. |
|
|
| msg298543 - (view) |
Author: Antoine Pitrou (pitrou) *  |
Date: 2017-07-17 17:12 |
| Uh, it's a pity this patch has been overlooked. Gareth, would you want to make a Github PR out of this? |
|
|
| msg298546 - (view) |
Author: Gareth Rees (gdr@garethrees.org) * |
Date: 2017-07-17 17:41 |
| Has Antony Lee has made a copyright assignment? |
|
|
| msg298547 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2017-07-17 17:42 |
| According to the asterisk displayed right of his name, he has, yes. |
|
|
| msg298548 - (view) |
Author: Gareth Rees (gdr@garethrees.org) * |
Date: 2017-07-17 17:42 |
| (If he hasn't, I don't think I can make a PR because I read his patch and so any implementation I make now is based on his patch and so potentially infringes his copyright.) |
|
|
| msg298793 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2017-07-21 10:35 |
| New changeset 3913bad4957ac30e58a7ffe9279333ad176a8eea by Antoine Pitrou (Gareth Rees) in branch 'master': bpo-19896: Add typecodes 'q' and 'Q' to multiprocessing.sharedctypes (#2741) https://github.com/python/cpython/commit/3913bad4957ac30e58a7ffe9279333ad176a8eea |
|
|
| msg298797 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2017-07-21 11:00 |
| Unhappy buildbot: http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/1065/steps/test/logs/stdio ... File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_multiprocessing_fork.py", line 2, in import test._test_multiprocessing File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/_test_multiprocessing.py", line 3180, in class _Foo(Structure): File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/_test_multiprocessing.py", line 3184, in _Foo ('z', c_longlong,) NameError: name 'c_longlong' is not defined |
|
|
| msg298800 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2017-07-21 11:05 |
| Apparently that buildbot doesn't have libffi. I submitted a PR in https://github.com/python/cpython/pull/2802. |
|
|