Issue 20080: Unused variable in Lib/sqlite3/test/factory.py (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/64279

classification

process

Created on 2013-12-27 10:56 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (4)
msg206990 - (view)	Author: Vajrasky Kok (vajrasky) *	Date: 2013-12-27 10:56
There is unused variable t in Lib/sqlite3/test/factory.py. def CheckSqliteRowAsTuple(self): """Checks if the row object can be converted to a tuple""" self.con.row_factory = sqlite.Row row = self.con.execute("select 1 as a, 2 as b").fetchone() t = tuple(row) def CheckSqliteRowAsDict(self): Attached the patch to give the purpose to variable t.
msg206997 - (view)	Author: Eric V. Smith (eric.smith) *	Date: 2013-12-27 15:56
I think you want to either also testing the number of elements in t, or in just compare t to (row["a"], row["b"]) (untested).
msg207146 - (view)	Author: Vajrasky Kok (vajrasky) *	Date: 2014-01-02 05:20
Thanks, Eric! Attached the patch to address Eric's concern.
msg211287 - (view)	Author: Roundup Robot (python-dev)	Date: 2014-02-15 18:20
New changeset a87f284e14ea by Benjamin Peterson in branch '2.7': add missing test assertion (closes #20080) http://hg.python.org/cpython/rev/a87f284e14ea New changeset 66c7791d9841 by Benjamin Peterson in branch '3.3': add missing test assertion (closes #20080) http://hg.python.org/cpython/rev/66c7791d9841 New changeset 93d7f8223370 by Benjamin Peterson in branch 'default': merge 3.3 (#20080) http://hg.python.org/cpython/rev/93d7f8223370