Issue 20202: ArgumentClinic howto: document change in Py_buffer lifecycle management (original) (raw)

Created on 2014-01-09 06:47 by rmsr, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
argument_clinic_PyBuffer_release.patch rmsr,2014-01-12 21:44 verbiage tweaking
Messages (5)
msg207728 - (view) Author: Ryan Smith-Roberts (rmsr) * Date: 2014-01-09 06:47
Almost didn't catch that PyBuffer_Release isn't needed. Also we need a verb/adjective for applying AC. Cure? "zlibmodule has already been cured."
msg207814 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2014-01-10 01:30
I've got a bunch of doc improvements in the rollup patch in #20214. I invite you to give it a review. If that looks suitable please close this issue. As for a verb, I've been using "convert". "zlibmodule has already been converted to work with Argument Clinic".
msg207982 - (view) Author: Ryan Smith-Roberts (rmsr) * Date: 2014-01-12 21:44
Thank you for including the doc change in your other patch. As the grammar was off, instead of just fixing it I naturally rewrote it. Use this patch or just remove the extraneous "for you" as you prefer.
msg207983 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2014-01-12 22:00
Fixed in revision 43e109ca9018. Well, changed anyway, maybe it's still not wonderful text.
msg208061 - (view) Author: Ryan Smith-Roberts (rmsr) * Date: 2014-01-14 00:12
Even more imperative than my version. Excellent!
History
Date User Action Args
2022-04-11 14:57:56 admin set github: 64401
2014-01-14 00:12:39 rmsr set status: open -> closedmessages: +
2014-01-12 22:00:14 larry set messages: +
2014-01-12 21:44:44 rmsr set files: + argument_clinic_PyBuffer_release.patchkeywords: + patchmessages: +
2014-01-10 01:30:09 larry set messages: +
2014-01-09 06:47:42 rmsr create