Issue 20307: Android's failure to expose SYS_* system call constants causes _posixsubprocess cross-compilation to fail (original) (raw)

Created on 2014-01-19 18:27 by shiz, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (6)
msg208488 - (view)	Author: Shiz (shiz) *	Date: 2014-01-19 18:27
Bionic, Android's C library, fails to expose the SYS_* constants used for the syscall(1) interface, which causes compilation of the _posixsubprocess module to fail as it directly attempts to call SYS_getdents64. Attached is an experimental patch that manually defines SYS_getdents64 from Bionic's internals.
msg208490 - (view)	Author: Shiz (shiz) *	Date: 2014-01-19 18:41
I of course meant the syscall(2) interface, not syscall(1).
msg208607 - (view)	Author: Gregory P. Smith (gregory.p.smith) *	Date: 2014-01-21 03:57
The patch seems reasonable. i'd modify it slightly to include a check the SYS_getdents64 is not already defined before doing the #define.
msg208611 - (view)	Author: Shiz (shiz) *	Date: 2014-01-21 04:25
That's probably a good idea. Fixed patch attached.
msg208612 - (view)	Author: Shiz (shiz) *	Date: 2014-01-21 04:26
Please take note of the discussion in issue 20305 if you were planning to merge this, by the way.
msg216204 - (view)	Author: Roundup Robot (python-dev)	Date: 2014-04-14 20:32
New changeset 211eeb97b352 by Gregory P. Smith in branch '3.4': Add conditional code for android's lack of definition of SYS_getdent64. http://hg.python.org/cpython/rev/211eeb97b352 New changeset 9f89958ded0a by Gregory P. Smith in branch 'default': Add conditional code for android's lack of definition of SYS_getdent64. http://hg.python.org/cpython/rev/9f89958ded0a