| msg209036 - (view) |
Author: Nikolaus Rath (nikratio) * |
Date: 2014-01-24 04:53 |
| (This issue was branched of from #9521). When parsing XML, etree currently skips over all processing instructions and comments. However, both can be represented in the tree and are also written out when generating XML. The attached patch documents this (IMO surprising) behavior. |
|
|
| msg209265 - (view) |
Author: Nikolaus Rath (nikratio) * |
Date: 2014-01-26 01:33 |
| I've also attached a testcase to confirm that the docpatch reflects current behavior, and to make sure that anticipated enhancements in Python 3.5 behave in a backwards compatible way. |
|
|
| msg214076 - (view) |
Author: PCManticore (Claudiu.Popa) *  |
Date: 2014-03-19 11:03 |
| Hello. I left a couple of comments on Rietveld. |
|
|
| msg214803 - (view) |
Author: Stefan Behnel (scoder) *  |
Date: 2014-03-25 10:33 |
| I think you attached the wrong file. |
|
|
| msg214873 - (view) |
Author: Nikolaus Rath (nikratio) * |
Date: 2014-03-26 00:32 |
| Indeed I did, here's the correct patch. Thanks! |
|
|
| msg215235 - (view) |
Author: Eli Bendersky (eli.bendersky) * |
Date: 2014-03-31 13:25 |
| The patch appears to contain code (tests) along with the documentation. Is this intended? This issue is not tagged properly if it is. I'd suggest to split them to separate patches. |
|
|
| msg215250 - (view) |
Author: Nikolaus Rath (nikratio) * |
Date: 2014-03-31 16:37 |
| Yes, the new testcases were deliberately included. I submitted the patch prior to the 3.4 release, am I right that at that point this wouldn't have been a problem? I have attached a new patch containing just the doc changes. I hope that's still acceptable for inclusion in 3.4 (and maybe 3.3? not sure if there'll be another bugfix release). |
|
|
| msg215381 - (view) |
Author: Eli Bendersky (eli.bendersky) * |
Date: 2014-04-02 13:27 |
| I left some comments in Rietveld. There shouldn't be a problem getting these into 3.4 too - doc changes are usually excempt from most restrictions. |
|
|
| msg215415 - (view) |
Author: Nikolaus Rath (nikratio) * |
Date: 2014-04-03 01:46 |
| Thanks for your feedback! I've attached an updated patch. |
|
|
| msg215445 - (view) |
Author: Roundup Robot (python-dev) |
Date: 2014-04-03 13:15 |
| New changeset 871278b87c62 by Eli Bendersky in branch '3.4': Issue #20375: Clarify ET's parsing of comments and processing instructions. http://hg.python.org/cpython/rev/871278b87c62 New changeset 5c3166ec80e1 by Eli Bendersky in branch 'default': Issue #20375: Clarify ET's parsing of comments and processing instructions. http://hg.python.org/cpython/rev/5c3166ec80e1 |
|
|
| msg215446 - (view) |
Author: Eli Bendersky (eli.bendersky) * |
Date: 2014-04-03 13:16 |
| Thanks. Doc patch committed with some slight rewording. Would you like to prepare a separate patch for the tests, default branch only this time? |
|
|
| msg215465 - (view) |
Author: Nikolaus Rath (nikratio) * |
Date: 2014-04-03 20:19 |
| Thanks for the commit! My intention is to fix the behavior itself for 3.5 (see issue 9521), so I think adding testcases for the old behavior in the meantime isn't necessary. |
|
|
| msg215471 - (view) |
Author: Eli Bendersky (eli.bendersky) * |
Date: 2014-04-03 21:39 |
| On Thu, Apr 3, 2014 at 1:19 PM, Nikolaus Rath <report@bugs.python.org>wrote: > > Nikolaus Rath added the comment: > > Thanks for the commit! > > My intention is to fix the behavior itself for 3.5 (see issue 9521), so I > think adding testcases for the old behavior in the meantime isn't necessary. > Fair enough. So you can close this issue, then. |
|
|