Issue 20377: Argument Clinic: get rid of the "_impl" suffix (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/64576

classification

process

Created on 2014-01-24 08:30 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg209045 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2014-01-24 08:30
For now most hand-written functions which use Argument Clinic have the "_impl" suffix and generated wrapper functions without the "_impl" suffix are less interested and visible to developer (generated *_METHODDEF macros are used in method list). I propose to revert things and name implementation functions without the "_impl" suffix, but add the "_wrapper" (or "_method"?) suffix to generated wrapper functions.
msg209047 - (view)	Author: Larry Hastings (larry) *	Date: 2014-01-24 08:53
We had this discussion already, some months ago. The consensus was to leave it the way it is.
msg209050 - (view)	Author: Larry Hastings (larry) *	Date: 2014-01-24 09:00
For the record, I was actually in favor of swapping them. You can try bringing it up again on python-dev if you like, but I'm not sure there's anything really new to say.
msg209061 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2014-01-24 10:55
Could you please provide a link on this discussion? There were too many discussions and I had quickly lost them. Argument Clinic was changed too much for last weeks, so perhaps consensus is changed.
msg209062 - (view)	Author: Larry Hastings (larry) *	Date: 2014-01-24 10:57
I'm sorry, but I simply don't have the time to spend to dig it up right now. It was a while ago and I'm not sure exactly where to look. I dimly recall it was last year, probably during September-December, and that both Nick and I were in it. It was probably in python-dev but it might have been on the tracker.