Issue 20457: Use partition and enumerate make getopt easier (original) (raw)
Created on 2014-01-31 16:16 by dongwm, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Messages (7) |
|
|
| msg211283 - (view) |
Author: Ezio Melotti (ezio.melotti) *  |
Date: 2014-02-15 15:51 |
| Thanks for the patches. Are these parts of the code covered by tests? If not, can you also provide tests for it? |
|
|
| msg211799 - (view) |
Author: dongwm (dongwm) * |
Date: 2014-02-21 04:47 |
| Yes, it has tests. I just modified do_longs and short_has_arg. In Lib/test/test_getopt.py, test_do_longs and test_short_has_arg can do it. |
|
|
| msg211800 - (view) |
Author: dongwm (dongwm) * |
Date: 2014-02-21 04:49 |
| I have signed the contributor agreement form. The new version of the official web site seem some css style display problems. |
|
|
| msg212104 - (view) |
Author: Raymond Hettinger (rhettinger) * |
Date: 2014-02-24 14:49 |
| FWIW, I don't find the new patch to be any clearer than the original. |
|
|
| msg212157 - (view) |
Author: dongwm (dongwm) * |
Date: 2014-02-25 02:22 |
| Oh, really no big improvement in function, but I have been using the functionality provided by python. |
|
|
| msg212162 - (view) |
Author: Raymond Hettinger (rhettinger) * |
Date: 2014-02-25 05:47 |
| I recommend we leave the code alone. No need for code churn unless there is a real improvement in code quality. |
|
|
| msg221041 - (view) |
Author: Ezio Melotti (ezio.melotti) * |
Date: 2014-06-19 22:15 |
| Based on Raymond's comment I'm going to close this. Thanks anyway for the patch. |
|
|
| History |
|
|
|
| Date |
User |
Action |
Args |
| 2022-04-11 14:57:57 |
admin |
set |
github: 64656 |
| 2014-06-19 22:15:16 |
ezio.melotti |
set |
status: open -> closedresolution: rejectedmessages: + stage: patch review -> resolved |
| 2014-02-25 05:47:57 |
rhettinger |
set |
messages: + |
| 2014-02-25 02:22:53 |
dongwm |
set |
messages: + |
| 2014-02-24 14:49:25 |
rhettinger |
set |
nosy: + rhettingermessages: + |
| 2014-02-21 04:49:39 |
dongwm |
set |
messages: + |
| 2014-02-21 04:47:10 |
dongwm |
set |
messages: + |
| 2014-02-15 15:51:19 |
ezio.melotti |
set |
versions: + Python 3.5, - Python 3.1, Python 2.7, Python 3.2, Python 3.3nosy: + ezio.melottimessages: + stage: patch review |
| 2014-01-31 16:31:05 |
ethan.furman |
set |
nosy: + ethan.furman |
| 2014-01-31 16:16:54 |
dongwm |
set |
files: + getopt_3.3.patchkeywords: + patch |
| 2014-01-31 16:16:40 |
dongwm |
create |
|