original ) (raw ) Issue20736
Created on 2014-02-22 22:16 by baikie , last changed 2022-04-11 14:57 by admin . This issue is now closed .
Files
File name
Uploaded
Description
Edit
test_socket-platform.diff baikie,2014-02-22 22:16
Check for sys.platform == "linux" rather than "linux2"
Messages (4)
msg211965 - (view) Author: David Watson (baikie)
Date: 2014-02-22 22:16
In test_socket, the decorator on SendmsgStreamTests.testSendmsgDontWait still checks for the old sys.platform value of "linux2", with the result that the test is always skipped, when in fact the test is for a Linux facility. Patch attached for 3.3 and above.
msg231369 - (view) Author: Serhiy Storchaka (serhiy.storchaka) *
Date: 2014-11-19 11:21
LGTM.
msg231370 - (view) Author: Roundup Robot (python-dev)
Date: 2014-11-19 11:24
New changeset fb06c8ccfd41 by Serhiy Storchaka in branch '3.4': Issue #20736 : testSendmsgDontWait in test_socket no longer skipped on Linux. https://hg.python.org/cpython/rev/fb06c8ccfd41 New changeset 23ab1197df0b by Serhiy Storchaka in branch 'default': Issue #20736 : testSendmsgDontWait in test_socket no longer skipped on Linux. https://hg.python.org/cpython/rev/23ab1197df0b
msg231371 - (view) Author: Serhiy Storchaka (serhiy.storchaka) *
Date: 2014-11-19 11:27
Thank you for your report and patch David.
History
Date
User
Action
Args
2022-04-11 14:57:59
admin
set
github: 64935
2014-11-19 11:27:22
serhiy.storchaka
set
status: open -> closedresolution: fixedmessages: + stage: commit review -> resolved
2014-11-19 11:24:21
python-dev
set
nosy: + python-dev messages: +
2014-11-19 11:21:14
serhiy.storchaka
set
versions: - Python 3.3nosy: + serhiy.storchaka messages: + assignee: serhiy.storchaka stage: commit review
2014-02-22 22:16:08
baikie
create
