Issue 20912: [zipfile.py]: Make zip directory attributes more friendly for MS-Windows (original) (raw)

Created on 2014-03-13 16:44 by vmurashev, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
zipfile.py.diff vmurashev,2014-03-13 16:44 diff for zipfile.py
zipfile_dirattrs.patch serhiy.storchaka,2014-08-18 09:46 review
Messages (5)
msg213416 - (view) Author: Vitaly Murashev (vmurashev) * Date: 2014-03-13 16:44
When I use 'zip' command-line tool on my Ubuntu 10.04 to pack a directory in zip-archive, it internally assigns '0x41ed0010' attributes for it. 0x41ed0010 = 0x41ed << 0xfff + 0x0010 Where: 0x41ed - unix attributes (40755) 0x0010 - means # MS-DOS directory flag At the same time zipfile.py doesn't provide MS-DOS directory flag. It seems be a good idea to do it. Patch suggested over 3.3.3 code-base.
msg225486 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-08-18 09:46
Looks good. But writestr() should be updated too. Some users use it to add a directory to ZIP file. Here is a patch with tests. It also changes attributes of regular file added by writestr().
msg225804 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-08-24 08:46
Could shutil experts please comment this patch?
msg226401 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-09-05 06:24
If there are no objections I'll commit the patch soon.
msg227381 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-09-23 19:45
New changeset c6b884483cd6 by Serhiy Storchaka in branch '2.7': Issue #20912: Now directories added to ZIP file have correct Unix and MS-DOS https://hg.python.org/cpython/rev/c6b884483cd6 New changeset b06e25a357de by Serhiy Storchaka in branch '3.4': Issue #20912: Now directories added to ZIP file have correct Unix and MS-DOS https://hg.python.org/cpython/rev/b06e25a357de New changeset 051105a95461 by Serhiy Storchaka in branch 'default': Issue #20912: Now directories added to ZIP file have correct Unix and MS-DOS https://hg.python.org/cpython/rev/051105a95461
History
Date User Action Args
2022-04-11 14:57:59 admin set github: 65111
2014-09-23 20:30:03 serhiy.storchaka set status: open -> closedresolution: fixedstage: patch review -> resolved
2014-09-23 19:45:17 python-dev set nosy: + python-devmessages: +
2014-09-05 06:24:23 serhiy.storchaka set messages: +
2014-08-24 08:46:36 serhiy.storchaka set nosy: + christian.heimes, tarek, hynekmessages: +
2014-08-18 09:47:34 serhiy.storchaka set assignee: serhiy.storchaka
2014-08-18 09:46:30 serhiy.storchaka set files: + zipfile_dirattrs.patchstage: test needed -> patch reviewmessages: + versions: - Python 3.3
2014-03-13 18:49:13 serhiy.storchaka set nosy: + serhiy.storchakastage: test neededversions: + Python 2.7
2014-03-13 16:44:21 vmurashev create