Issue 21610: load_module not closing opened files (original) (raw)

Issue21610

Created on 2014-05-29 21:10 by mattip, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
close_fp_2.7.patch mattip,2014-05-29 21:10 patch against 2.7 review
Messages (5)
msg219367 - (view) Author: mattip (mattip) * Date: 2014-05-29 21:10
imputil and modulefinder are opening files but not actively closing them. This causes problems for pypy and is not clean.
msg219369 - (view) Author: mattip (mattip) * Date: 2014-05-29 21:15
the issue has already been fixed on HEAD but not backported to 2.7
msg219391 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2014-05-30 14:27
I don't have a Python 2.7 repo handy but the patch LGTM.
msg237704 - (view) Author: mattip (mattip) * Date: 2015-03-09 21:14
ping
msg237826 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-03-11 00:07
New changeset 5a5d4073d46a by Benjamin Peterson in branch '2.7': close files explicit (closes #21610) https://hg.python.org/cpython/rev/5a5d4073d46a
History
Date User Action Args
2022-04-11 14:58:04 admin set github: 65809
2015-03-11 00:07:02 python-dev set status: open -> closednosy: + python-devmessages: + resolution: fixedstage: patch review -> resolved
2015-03-10 07:51:13 berker.peksag set nosy: + berker.peksagstage: patch review
2015-03-09 21:14:57 mattip set messages: +
2014-05-30 14:27:54 brett.cannon set nosy: + brett.cannonmessages: +
2014-05-29 21:15:14 mattip set messages: +
2014-05-29 21:10:42 mattip create