original ) (raw ) Issue21758
Created on 2014-06-14 16:17 by vajrasky , last changed 2022-04-11 14:58 by admin . This issue is now closed .
Messages (4)
msg220567 - (view) Author: Vajrasky Kok (vajrasky) *
Date: 2014-06-14 16:17
subprocess_shell in asyncio accepts cmd as a string or a bytes but the test unit, the documentation and the exception indicates that it only accepts a string.
msg220620 - (view) Author: STINNER Victor (vstinner) *
Date: 2014-06-15 09:12
IMO it's fine to support bytes on UNIX, os.fsencode() is well defined. On Windows, we may use the same decoder.
msg220962 - (view) Author: Roundup Robot (python-dev)
Date: 2014-06-19 10:51
New changeset 24c356168cc8 by Victor Stinner in branch '3.4': Closes #21758 : asyncio doc: mention explicitly that subprocess parameters are http://hg.python.org/cpython/rev/24c356168cc8 New changeset b57cdb945bf9 by Victor Stinner in branch 'default': (Merge 3.4) Closes #21758 : asyncio doc: mention explicitly that subprocess http://hg.python.org/cpython/rev/b57cdb945bf9
msg220963 - (view) Author: STINNER Victor (vstinner) *
Date: 2014-06-19 10:52
A "string" can be a bytes string or a character string. I modified the documentation to be more explicitly, but IMO it's fine to keep "string" term in unit tests and error messages. You should not get the "string" error message if you pass a bytes or str object.
History
Date
User
Action
Args
2022-04-11 14:58:04
admin
set
github: 65957
2014-06-19 15:40:51
vstinner
set
status: open -> closedresolution: fixed
2014-06-19 10:52:45
vstinner
set
status: closed -> openresolution: fixed -> (no value)messages: + stage: resolved ->
2014-06-19 10:51:28
python-dev
set
status: open -> closednosy: + python-dev messages: + resolution: fixedstage: resolved
2014-06-15 09:12:53
vstinner
set
messages: +
2014-06-14 16:17:58
vajrasky
create
