Issue 22053: turtledemo: clean up start and stop, fix warning (original) (raw)
Created on 2014-07-23 21:24 by terry.reedy, last changed 2022-04-11 14:58 by admin. This issue is now closed.
Messages (6)
Author: Terry J. Reedy (terry.reedy) * 
Date: 2014-07-23 21:24
The patch adds a main function with the minimum needed to start the mainloop. It omits the 'while RUN' loop and development code for catching exceptions while running. They should never happen, and silently suppressing tracebacks is a bad idea.
The patch also deletes the unneeded sys.exit() call from _destroy. In 3.x debug builds, this call results in the following clipped warning being printed in the startup console.
while executing"46111032_destroy" (command for "WM_DELETE_WINDOW" window manager protocol)
These no longer occur when sys.exit() is removed.
Turtledemo works fine with these changes.
Author: Roundup Robot (python-dev) 
Date: 2014-07-23 21:28
New changeset 823f5507bd86 by Terry Jan Reedy in branch '2.7': Issue #22053: Cleanup turtledemo start and stop and fix debug shutdown warning. http://hg.python.org/cpython/rev/823f5507bd86
New changeset 57531d65cdd4 by Terry Jan Reedy in branch '3.4': Issue #22053: Cleanup turtledemo start and stop and fix debug shutdown warning. http://hg.python.org/cpython/rev/57531d65cdd4
Author: Roundup Robot (python-dev)
Date: 2014-07-25 06:27
New changeset 7a55b34f1db2 by Terry Jan Reedy in branch '2.7': Issue #22053: Make help work, after previous patch for this issue disabled it http://hg.python.org/cpython/rev/7a55b34f1db2
New changeset c26862955342 by Terry Jan Reedy in branch '3.4': Issue #22053: Make help work, after previous patch for this issue disabled it http://hg.python.org/cpython/rev/c26862955342
New changeset 8c972d528f06 by Terry Jan Reedy in branch 'default': Issue #22053: Make help work, after previous patch for this issue disabled it http://hg.python.org/cpython/rev/8c972d528f06
Author: Terry J. Reedy (terry.reedy) *
Date: 2014-07-25 06:43
Removal of 'demo' as a global name disabled help callbacks. I could have added 'global demo' to main(), but I decided to refactor and remove duplicate code instead. For 3.5, however, refactor would not merge because of #10291, so I made the simplest fix pending a decision on what to do.
Author: Terry J. Reedy (terry.reedy) *
Date: 2014-08-15 04:51
After backporting 004fe3449193 (#10921 3.5 patch) with changes as 7708f80940b0, forward port to 3.5 the 3.4 patch c26862955342 that did not merge before. The 3.4 and 3.5 files are identical.
Misdirected changeset notices:
New changeset 4349bbc21ca7 by Terry Jan Reedy in branch 'default': Issue #22065: forward port the changes in c26862955342, update docstring with http://hg.python.org/cpython/rev/4349bbc21ca7
New changeset 59cc3bfdac4b by Terry Jan Reedy in branch 'default': Issue #22065: Try the delete demohelp.txt part again. http://hg.python.org/cpython/rev/59cc3bfdac4b
Author: Roundup Robot (python-dev)
Date: 2014-08-15 04:57
New changeset 5aa3f4863dda by Terry Jan Reedy in branch '3.4': #22053: actually remove .txt files from 3.4. http://hg.python.org/cpython/rev/5aa3f4863dda
History
Date
User
Action
Args
2022-04-11 14:58:06
admin
set
github: 66252
2014-08-15 04:57:26
python-dev
set
messages: +
2014-08-15 04:51:33
terry.reedy
set
messages: +
2014-07-25 06:43:00
terry.reedy
set
messages: +
2014-07-25 06:27:08
python-dev
set
messages: +
2014-07-23 21:29:21
terry.reedy
set
status: open -> closed
resolution: fixed
stage: commit review -> resolved
2014-07-23 21:28:39
python-dev
set
nosy: + python-dev
messages: +
2014-07-23 21:24:33
terry.reedy
create