| msg224175 - (view) |
Author: Demian Brecht (demian.brecht) *  |
Date: 2014-07-28 18:09 |
| Creating this bug for clarity, but was encountered while investigating 22041 (now set as not a bug). When using set_tunnel with default port, the port value in the host header is set to "None": "send: b'POST [PATH] HTTP/1.1\r\nHost: [HOST]:None\r\nAccept-Encoding: identity\r\nContent-Length: 41\r\nAccept: text/plain\r\nContent-type: application/x-www-form-urlencoded\r\n\r\n[FORM_DATA]'" This issue seems to have been introduced in 3.4 when _tunnel_host and _tunnel_port were introduced to decouple the destination host and port from the proxy host and port. |
|
|
| msg224991 - (view) |
Author: Demian Brecht (demian.brecht) * |
Date: 2014-08-07 04:42 |
| Bump for review |
|
|
| msg231308 - (view) |
Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2014-11-18 08:49 |
| If call _get_hostport() in set_tunnel() then it should be removed in _tunnel(). As for tests, it would be better do not rely on implementation details. Instead you can monkey-patch the send() method of of HTTPConnection instance and check passed argument. |
|
|
| msg231834 - (view) |
Author: Demian Brecht (demian.brecht) * |
Date: 2014-11-28 22:37 |
| Thanks Serhiy, new patch addresses your comments. |
|
|
| msg232502 - (view) |
Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2014-12-11 22:39 |
| See also comments on Rietveld (e-mail notification likely fell in spam). |
|
|
| msg232508 - (view) |
Author: Demian Brecht (demian.brecht) * |
Date: 2014-12-12 05:20 |
| Thanks for the ping Serhiy, indeed the review notification email was sitting in spam. New patch addressing review comments as well as rectifying my own silliness. |
|
|
| msg232513 - (view) |
Author: Roundup Robot (python-dev) |
Date: 2014-12-12 07:36 |
| New changeset 676d6bcfc031 by Serhiy Storchaka in branch '3.4': Issue #22095: Fixed HTTPConnection.set_tunnel with default port. The port https://hg.python.org/cpython/rev/676d6bcfc031 New changeset ebe2072e5472 by Serhiy Storchaka in branch 'default': Issue #22095: Fixed HTTPConnection.set_tunnel with default port. The port https://hg.python.org/cpython/rev/ebe2072e5472 |
|
|
| msg232514 - (view) |
Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2014-12-12 07:47 |
| Thank you for your contribution Demian. |
|
|
| msg244341 - (view) |
Author: Roundup Robot (python-dev) |
Date: 2015-05-28 19:38 |
| New changeset 3b6e0720a69d by Serhiy Storchaka in branch '2.7': Issue #22095: Fixed HTTPConnection.set_tunnel with default port. The port https://hg.python.org/cpython/rev/3b6e0720a69d |
|
|
| msg244342 - (view) |
Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-05-28 19:44 |
| Backported to 2.7 because this is needed to support proxy with a port in urllib/urllib2 as documented. See . |
|
|