Issue 22217: Reprs for zipfile classes (original) (raw)

Issue22217

Created on 2014-08-17 17:05 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
zipfile_reprs.diff serhiy.storchaka,2014-08-17 17:06 review
zipfile_reprs_2.patch serhiy.storchaka,2014-08-21 06:48 review
Messages (5)
msg225451 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-08-17 17:05
Proposed patch implements __repr__() methods of three zipfile classes: ZipFile, ZipInfo and ZipExtFile. Example: >>> import zipfile >>> zf = zipfile.ZipFile('/usr/share/doc/texlive-base/support/makeindex/ind-src.zip') >>> zf <zipfile.ZipFile filename='/usr/share/doc/texlive-base/support/makeindex/ind-src.zip' mode='r'> >>> zf.infolist()[:2] [<ZipInfo filename='ind-src/' filemode=drwxr-xr-x external_attr=0x10>, <ZipInfo filename='ind-src/fig1.tex' compress_type=deflate filemode=-r--r--r-- external_attr=0x1 file_size=1553 compress_size=518>] >>> zf.open('ind-src/fig1.tex') <zipfile.ZipExtFile name='ind-src/fig1.tex' mode='r' compress_type=deflate>
msg225601 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-08-21 06:48
Updated patch addresses Berker's comments.
msg230132 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2014-10-28 09:20
LGTM
msg230244 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-10-29 20:53
New changeset 82fd95c2851b by Serhiy Storchaka in branch 'default': Issue #22217: Implemented reprs of classes in the zipfile module. https://hg.python.org/cpython/rev/82fd95c2851b
msg230245 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-10-29 21:01
Thank you Berker and Ezio for your reviews.
History
Date User Action Args
2022-04-11 14:58:07 admin set github: 66413
2014-10-29 21:01:42 serhiy.storchaka set status: open -> closedresolution: fixedmessages: + stage: commit review -> resolved
2014-10-29 20:53:40 python-dev set nosy: + python-devmessages: +
2014-10-28 09:20:32 ezio.melotti set nosy: + ezio.melottimessages: + stage: patch review -> commit review
2014-08-21 06:48:13 serhiy.storchaka set files: + zipfile_reprs_2.patchmessages: +
2014-08-17 17:06:37 serhiy.storchaka set files: + zipfile_reprs.diffkeywords: + patch
2014-08-17 17:05:43 serhiy.storchaka create