original ) (raw )Created on 2014-08-19 08:05 by serhiy.storchaka , last changed 2022-04-11 14:58 by admin . This issue is now closed .
Messages (9)
msg225521 - (view) Author: Serhiy Storchaka (serhiy.storchaka) *
Date: 2014-08-19 08:05
TarFile iteration can be simplified by using a generator instead of iterator class. Attached patch get rid of the TarIter class and decrease sources size by 16 lines.
msg237454 - (view) Author: Mark Lawrence (BreamoreBoy) *
Date: 2015-03-07 16:06
LGTM at a quick glance. Can we have a formal patch review please.
msg237479 - (view) Author: Martin Panter (martin.panter) *
Date: 2015-03-07 22:39
The code changes look correct and worthwhile to me. Just added some suggestions for the comments, which would become out of date.
msg237521 - (view) Author: Serhiy Storchaka (serhiy.storchaka) *
Date: 2015-03-08 08:57
The patch doesn't fix a bug and doesn't add new feature. It just rewrites the code in more clear manner (in my eyes). So I leave applying or rejecting the patch on Lars.
msg247599 - (view) Author: Robert Collins (rbcollins) *
Date: 2015-07-29 18:32
@serhiy could you update the patch with the review feedback? Thanks. Moving back to patch review. Lars hasn't commented on this in a year, so I think we should go ahead once the patch is fixed: e.g. you should update the comments and commit it directly.
msg247863 - (view) Author: Serhiy Storchaka (serhiy.storchaka) *
Date: 2015-08-02 12:00
Updated patch addresses Martin's comments. Thanks Martin.
msg247901 - (view) Author: Raymond Hettinger (rhettinger) *
Date: 2015-08-02 21:42
The patch looks good and passes tests. Go ahead and apply.
msg256718 - (view) Author: Roundup Robot (python-dev)
Date: 2015-12-19 07:43
New changeset a8f24e26abc7 by Serhiy Storchaka in branch 'default': Issue #22227 : The TarFile iterator is reimplemented using generator. https://hg.python.org/cpython/rev/a8f24e26abc7
msg256719 - (view) Author: Serhiy Storchaka (serhiy.storchaka) *
Date: 2015-12-19 07:45
Thanks Martin and Raymond for reviews.
History
Date
User
Action
Args
2022-04-11 14:58:07
admin
set
github: 66423
2015-12-19 07:45:22
serhiy.storchaka
set
status: open -> closedresolution: fixedmessages: + stage: commit review -> resolved
2015-12-19 07:43:45
python-dev
set
nosy: + python-dev messages: +
2015-08-02 21:42:07
rhettinger
set
assignee: lars.gustaebel -> serhiy.storchaka messages: + nosy: + rhettinger
2015-08-02 12:31:29
rbcollins
set
stage: patch review -> commit review
2015-08-02 12:00:15
serhiy.storchaka
set
files: + tarfile_tariter_2.diff messages: + versions: + Python 3.6, - Python 3.5
2015-07-29 18:32:55
rbcollins
set
nosy: + rbcollins messages: + stage: commit review -> patch review
2015-03-08 08:57:18
serhiy.storchaka
set
assignee: lars.gustaebel messages: +
2015-03-08 04:43:36
berker.peksag
set
stage: patch review -> commit review
2015-03-07 22:39:55
martin.panter
set
messages: +
2015-03-07 22:34:36
martin.panter
set
nosy: + martin.panter
2015-03-07 16:06:29
BreamoreBoy
set
nosy: + BreamoreBoy messages: +
2014-08-19 08:05:55
serhiy.storchaka
create
