Issue 22266: fix reliance on refcounting in tarfile.gzopen (original) (raw)

Created on 2014-08-24 20:35 by bdkearns, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (5)
msg225836 - (view)	Author: Brian Kearns (bdkearns) *	Date: 2014-08-24 20:35
tarfile.gzopen relies on refcounting to close the fileobj when the fileobj is created during the call to gzopen (when it is not passed in). Since the fileobj is created outside of GzipFile, GzipFile does not take responsibility for closing the fileobj (so no one does, aside from the GC, which leads to unexpected behavior when using a non-refcounted GC). This is fixed by having GzipFile open the fileobj itself, so it does take responsibility for closing it when necessary. The same approach is taken in tarfile.py in py3k branch.
msg225848 - (view)	Author: Benjamin Peterson (benjamin.peterson) *	Date: 2014-08-24 23:35
I think technically this changes semantics, since the construction of the GzipFile is no longer in the main try-except. You should probably backport the full 3.x behavior.
msg225864 - (view)	Author: Brian Kearns (bdkearns) *	Date: 2014-08-25 04:32
Yes, I guess that makes sense (though this behavior is undocumented and untested...)
msg225876 - (view)	Author: Brian Kearns (bdkearns) *	Date: 2014-08-25 14:52
Updated to backport all the cases where 3.x handles this issue.
msg226007 - (view)	Author: Roundup Robot (python-dev)	Date: 2014-08-28 00:31
New changeset 6f0dae921bee by Benjamin Peterson in branch '2.7': properly handle file closing in error cases (closes #22266) http://hg.python.org/cpython/rev/6f0dae921bee