Issue 22398: Tools/msi enhancements for 2.7 (original) (raw)

Issue22398

Created on 2014-09-12 18:46 by steve.dower, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (4)
msg226839 - (view)	Author: Steve Dower (steve.dower) *	Date: 2014-09-12 18:46
This patch has some minor changes to the build scripts for Python 2.7 on Windows. They're fully tested on my build machine, but I wanted someone who's more familiar with how the buildbots are set up to either confirm that the Tools/msi scripts are not used or that the changes won't have an impact. The Tools/msi/msi.py changes to use environment variables are mostly to make my life easier. Apparently the old way was to actually modify the file before making an official release... The Tools/msi/msilib.py fix is necessary because of some new files that were added for 2.7.9. Technically it's a release blocker, though it won't actually hold anything up since I spotted it.
msg226842 - (view)	Author: Zachary Ware (zach.ware) *	Date: 2014-09-12 20:10
Actually, I think the method Martin used was to create a local config.py in Tools/msi/, which provided the proper settings for the release. See http://hg.python.org/cpython/file/2.7/Tools/msi/msi.py#l37 Either way, the buildbots are completely unaffected by Tools/msi, and I don't think anything actually uses PCbuild/build_tkinter.py (unless you do :)), so since the script is now yours, I'd say you're clear to change as you like.
msg226843 - (view)	Author: Steve Dower (steve.dower) *	Date: 2014-09-12 20:18
Thanks for confirming. Somehow I never noticed the import config line - guess that's a pattern I'm not really used to seeing. Still, I prefer having the env variables there as I invoke the scripts through some batch files (very specific to my machine, unfortunately, but the 3.5 ones will be more generic). And since you mention it, apparently I'm not using build_tkinter.py any more either. I was at one point, hence the fix. I'll leave it in there - we can probably remove the file completely but no harm in leaving it.
msg226844 - (view)	Author: Roundup Robot (python-dev)	Date: 2014-09-12 20:19
New changeset 5c55a7bfec0c by Steve Dower in branch '2.7': #22398 Tools/msi enhancements for 2.7 http://hg.python.org/cpython/rev/5c55a7bfec0c