Issue 22824: Update reprlib to use set literals (original) (raw)

Created on 2014-11-09 03:22 by rhettinger, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue22824.diff berker.peksag,2014-11-10 00:12 review
issue22824_v2.diff berker.peksag,2014-11-10 00:29 review
issue22824_3.diff serhiy.storchaka,2014-11-10 08:33 review
Messages (8)
msg230880 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2014-11-09 03:22
Currently reprlib outputs: >>> reprlib.repr(set('supercalifragilisticexpialidocious')) "set(['a', 'c', 'd', 'e', 'f', 'g', ...])" This should be: "{'a', 'c', 'd', 'e', 'f', 'g', ...}"
msg230922 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2014-11-10 00:12
Here's a patch to use set literals and frozenset({'a'}) in reprlib.
msg230923 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2014-11-10 00:21
That looks great. Go ahead an apply (with a MISC/NEWS entry and an update to the example on line 22 of Docs/tutorial/stdlib2.rst).
msg230924 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2014-11-10 00:29
Thanks for the review, Raymond. Patch updated: - Updated the documentation - Added two test cases for set literals - Replaced old run_unittest calls with ``unittest.main()``
msg230935 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-11-10 06:31
New changeset 147fda13bec8 by Raymond Hettinger in branch 'default': Issue #22824: Updated reprlib output format for sets to use set literals. https://hg.python.org/cpython/rev/147fda13bec8
msg230936 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2014-11-10 06:31
Thanks for the patch.
msg230942 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-10 08:33
The repr of empty array() should be fixed too.
msg231213 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-11-15 18:59
New changeset cf5b910ac4c8 by Raymond Hettinger in branch 'default': Issue #22824: Simplify reprlib output format for empty arrays https://hg.python.org/cpython/rev/cf5b910ac4c8
History
Date User Action Args
2022-04-11 14:58:10 admin set github: 67013
2014-11-15 18:59:09 python-dev set messages: +
2014-11-10 08:33:41 serhiy.storchaka set files: + issue22824_3.diffnosy: + serhiy.storchakamessages: +
2014-11-10 07:08:06 berker.peksag set stage: patch review -> resolved
2014-11-10 06:31:33 rhettinger set status: open -> closedresolution: fixedmessages: +
2014-11-10 06:31:01 python-dev set nosy: + python-devmessages: +
2014-11-10 00:29:27 berker.peksag set files: + issue22824_v2.diffmessages: +
2014-11-10 00:21:27 rhettinger set assignee: berker.peksagmessages: +
2014-11-10 00:12:23 berker.peksag set files: + issue22824.diffkeywords: + patchmessages: + stage: needs patch -> patch review
2014-11-09 03:24:27 ezio.melotti set nosy: + ezio.melotticomponents: + Library (Lib)stage: needs patch
2014-11-09 03:23:50 berker.peksag set nosy: + berker.peksag
2014-11-09 03:22:18 rhettinger create