Issue 22841: Avoid to use coroutine with add_signal_handler() (original) (raw)

Issue22841

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/67030

classification

Title: Avoid to use coroutine with add_signal_handler()
Type: Stage:
Components: asyncio Versions: Python 3.4, Python 3.5

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Ludovic.Gasc, gvanrossum, python-dev, vstinner, yselivanov
Priority: normal Keywords: patch

Created on 2014-11-10 23:35 by Ludovic.Gasc, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
add_signal_handler_no_coroutines.patch Ludovic.Gasc,2014-11-10 23:35
Messages (4)
msg230984 - (view) Author: Ludovic Gasc (Ludovic.Gasc) * Date: 2014-11-10 23:35
Hi, Victor Stinner suggested me during PyCON-FR to send you this: It's a pico-patch to forbid a coroutine as parameter of add_signal_handler(). I've added a test for that, the patch is based on the latest commit in Tulip. Thanks for your feedback. Regards.
msg231177 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-11-14 19:47
New changeset d244e1770f1b by Guido van Rossum in branch '3.4': - Issue #22841: Reject coroutines in asyncio add_signal_handler(). https://hg.python.org/cpython/rev/d244e1770f1b
msg231178 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2014-11-14 19:50
Applied to upstream tulip, 3.4, and 3.5. Thanks Ludovic!
msg231179 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-11-14 19:52
New changeset 44e77709daa4 by Guido van Rossum in branch 'default': - Issue #22841: Reject coroutines in asyncio add_signal_handler(). https://hg.python.org/cpython/rev/44e77709daa4
History
Date User Action Args
2022-04-11 14:58:10 admin set github: 67030
2014-11-25 14:36:13 vstinner set status: open -> closedresolution: fixed
2014-11-14 19:52:39 python-dev set messages: +
2014-11-14 19:50:28 gvanrossum set messages: +
2014-11-14 19:47:18 python-dev set nosy: + python-devmessages: +
2014-11-10 23:35:47 Ludovic.Gasc create