Issue 22883: Get rid of references to PyInt in Py3 sources (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/67072

classification

process

Created on 2014-11-16 14:12 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (3)
msg231246 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2014-11-16 14:12
There are several references to PyInt in outdated comments in .c and .h files: $ find * -name '*.[ch]' -exec egrep -n --color -- 'PyInt\b' '{}' + Include/longobject.h:34:/* It may be useful in the future. I've added it in the PyInt -> PyLong Modules/fcntlmodule.c:157: into either a large positive number (PyLong or PyInt on 64-bit Modules/fcntlmodule.c:158: platforms) or a negative number on others (32-bit PyInt) Modules/_json.c:813: PyInt, PyLong, or PyFloat. Modules/itertoolsmodule.c:3869: assert(cnt != PY_SSIZE_T_MAX && long_cnt == NULL && long_step==PyInt(1)); Python/ceval.c:4606:/* Extract a slice index from a PyInt or PyLong or an object with the
msg232419 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2014-12-10 12:02
I doubt that just removing PyInt is correct. At least in longobject.h current comment looks correct. And in fcntlmodule.c and itertoolsmodule.c proposed changes look questionable. There are also mentions of PyInt_* in *.rst and *.py files.
msg236128 - (view)	Author: Roundup Robot (python-dev)	Date: 2015-02-17 08:19
New changeset 2f0c1937d716 by Serhiy Storchaka in branch 'default': Issue #22883: Got rid of outdated references to PyInt and PyString in comments. https://hg.python.org/cpython/rev/2f0c1937d716 New changeset c8d08de14030 by Serhiy Storchaka in branch '3.4': Issue #22883: Update PyInt to PyLong in C API example. https://hg.python.org/cpython/rev/c8d08de14030 New changeset c0b2dacef35c by Serhiy Storchaka in branch 'default': Issue #22883: Update PyInt to PyLong in C API example. https://hg.python.org/cpython/rev/c0b2dacef35c