Issue 22902: Use 'ip' for uuid.getnode() (original) (raw)

Issue22902

Created on 2014-11-19 15:16 by bru, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
uuid_find_mac_with_ip.patch bru,2014-11-19 15:16 Patch for 'ip' usage in uuid.getnode() review
Messages (6)
msg231382 - (view) Author: Bruno Cauet (bru) * Date: 2014-11-19 15:16
Only linux, `uuid.getnode()` will use the Unix ddl, then ifconfig, then random. `ifconfig` is disappearing in favour of `ip` (from iproute2), which should be used. This patch ads `_ip_getnode` getter to `uuid.getnode()`
msg231384 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2014-11-19 15:22
IMO such change can wait for Python 3.5.
msg231388 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-19 16:26
LGTM.
msg231891 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-30 16:17
Bruno, could you please sign a Contributor Licensing Agreement? http://www.python.org/psf/contrib/contrib-form/ http://www.python.org/psf/contrib/
msg231898 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-11-30 18:41
New changeset 64bb01bce12c by Serhiy Storchaka in branch 'default': Issue #22902: The "ip" command is now used on Linux to determine MAC address https://hg.python.org/cpython/rev/64bb01bce12c
msg231899 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-30 18:44
Thank you for your contribution Bruno.
History
Date User Action Args
2022-04-11 14:58:10 admin set github: 67091
2014-11-30 18:44:10 serhiy.storchaka set status: open -> closedresolution: fixedmessages: + stage: commit review -> resolved
2014-11-30 18:41:16 python-dev set nosy: + python-devmessages: +
2014-11-30 16:17:31 serhiy.storchaka set assignee: serhiy.storchakatype: enhancementmessages: + stage: commit review
2014-11-19 16:26:40 serhiy.storchaka set messages: +
2014-11-19 15:22:31 vstinner set nosy: + vstinner, serhiy.storchakamessages: + versions: + Python 3.5, - Python 3.4
2014-11-19 15:16:34 bru create