Issue 2335: Backport set literals (original) (raw)

Created on 2008-03-17 17:38 by brett.cannon, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
backport_set_literal.diff alexandre.vassalotti,2009-08-04 22:28
Messages (9)
msg63692 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2008-03-17 17:38
Set literals need to be backported.
msg70455 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-07-31 01:52
I'm going to defer this to 2.7.
msg91279 - (view) Author: Alexandre Vassalotti (alexandre.vassalotti) * (Python committer) Date: 2009-08-04 22:28
Here is a patch for backporting set literals to the trunk.
msg91280 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2009-08-04 22:36
Guido, I thought you had decided for this to just be a 3.x feature. Alex, if this goes forward, were you also going to change the repr() for sets and the corresponding pprint code? Are set comprehensions on the radar screen also. IMO, these all go hand in hand.
msg91284 - (view) Author: Alexandre Vassalotti (alexandre.vassalotti) * (Python committer) Date: 2009-08-04 23:27
I think we should keep the repr() of sets as is to avoid breaking any code. And yes, I plan to port set comprehensions along with dict comprehension.
msg91289 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2009-08-05 00:35
Raymond, I know you see this differently, but personally I don't see a problem with 2.7 getting additional backports of 3.x features, as long as they are backwards compatible. While personally I wouldn't spend effort on this particular backport, I don't see a problem when someone volunteers a patch. In this specific case, I am fine with accepting set literals and set comprehensions as new syntax. I do agree that repr() needs to be kept the same as it was under 2.6.
msg91294 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2009-08-05 01:53
These all seem fine to me. Was just checking in because I thought you had previously pronounced otherwise.
msg96256 - (view) Author: Alexandre Vassalotti (alexandre.vassalotti) * (Python committer) Date: 2009-12-11 14:11
If there are no objections, I will commit this patch later this week.
msg97478 - (view) Author: Alexandre Vassalotti (alexandre.vassalotti) * (Python committer) Date: 2010-01-09 23:37
It been a long week, but this patch is now committed as r77400.
History
Date User Action Args
2022-04-11 14:56:31 admin set github: 46588
2010-01-09 23:37:29 alexandre.vassalotti set status: open -> closedresolution: acceptedmessages: + stage: patch review -> resolved
2009-12-11 14:11:00 alexandre.vassalotti set messages: +
2009-08-05 23:12:32 alexandre.vassalotti link issue2333 dependencies
2009-08-05 01:53:13 rhettinger set messages: +
2009-08-05 00:35:13 gvanrossum set assignee: gvanrossum -> messages: +
2009-08-04 23:27:33 alexandre.vassalotti set messages: +
2009-08-04 22:36:59 rhettinger set priority: critical -> normalnosy: + gvanrossum, rhettingermessages: + assignee: gvanrossum
2009-08-04 22:28:10 alexandre.vassalotti set files: + backport_set_literal.diffnosy: + alexandre.vassalottimessages: + keywords: + patchstage: patch review
2008-07-31 01:52:31 benjamin.peterson set nosy: + benjamin.petersonmessages: + versions: + Python 2.7, - Python 2.6
2008-03-17 20:10:26 brett.cannon set priority: release blocker -> critical
2008-03-17 17:38:45 brett.cannon create