Issue 23960: PyErr_SetImportError doesn't clean up on some errors (original) (raw)
Issue23960
Created on 2015-04-14 23:12 by blackfawn, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Messages (5) |
|
|
| msg241052 - (view) |
Author: Ofer Schwarz (blackfawn) * |
Date: 2015-04-14 23:12 |
| When creating kwargs to construct the ImportError, if PyDict_SetItemString fails the function returns without decref'ing the already-created locals. |
|
|
| msg264552 - (view) |
Author: Berker Peksag (berker.peksag) *  |
Date: 2016-04-30 11:52 |
| Thanks for the patch. I left review comments on Rietveld (click to the review link above). |
|
|
| msg264556 - (view) |
Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-04-30 13:35 |
| LGTM. |
|
|
| msg264581 - (view) |
Author: Roundup Robot (python-dev)  |
Date: 2016-05-01 06:07 |
| New changeset 5871b48f4c2e by Berker Peksag in branch '3.5': Issue #23960: Cleanup args and kwargs on error in PyErr_SetImportError https://hg.python.org/cpython/rev/5871b48f4c2e New changeset 94471357db08 by Berker Peksag in branch 'default': Issue #23960: Cleanup args and kwargs on error in PyErr_SetImportError https://hg.python.org/cpython/rev/94471357db08 |
|
|
| msg264582 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2016-05-01 06:07 |
| Thanks! |
|
|
| History |
|
|
|
| Date |
User |
Action |
Args |
| 2022-04-11 14:58:15 |
admin |
set |
github: 68148 |
| 2016-05-01 06:07:28 |
berker.peksag |
set |
status: open -> closedresolution: fixedmessages: + stage: commit review -> resolved |
| 2016-05-01 06:07:05 |
python-dev |
set |
nosy: + python-devmessages: + |
| 2016-04-30 13:35:53 |
serhiy.storchaka |
set |
nosy: + serhiy.storchakamessages: + stage: patch review -> commit review |
| 2016-04-30 11:52:45 |
berker.peksag |
set |
versions: + Python 3.6nosy: + berker.peksagmessages: + stage: patch review |
| 2015-04-14 23:12:48 |
blackfawn |
create |
|