Issue 24007: Write PyArg_Parse* format in a line with a function (original) (raw)

Issue24007

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/68195

classification

process

Created on 2015-04-19 18:30 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (4)
msg241531 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2015-04-19 18:30
Proposed patch makes Argument Clinic to output format argument of PyArg_Parse, PyArg_ParseTuple and PyArg_ParseTupleAndKeywords in a line with a function itself. First, this makes generated code more compact and easier to read and compare with old code. Second, it makes easier to grep sources for used format units. Format argument always (or almost always) is written in a line with a function.
msg241567 - (view)	Author: Larry Hastings (larry) *	Date: 2015-04-19 21:59
I don't care about this, but the patch looks fine. If this really helps then LGTM. Please hold off checking this in until after 3.5.0 alpha 4 is released.
msg241607 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2015-04-20 05:36
Actually it is not hard to me to apply the patch locally and regenerate clinic output if I need it. I propose this patch for mainstream only because think that it can be helpful for someone other. Thanks to moving all generated code into separated files, the code churn does not harm.
msg241893 - (view)	Author: Roundup Robot (python-dev)	Date: 2015-04-23 21:41
New changeset 151cab576cab by Serhiy Storchaka in branch 'default': Issue #24007: Argument Clinic now writes the format of PyArg_Parse*() at the https://hg.python.org/cpython/rev/151cab576cab